[pve-devel] [PATCH frr] add patch to change the starting order of mgmtd and zebra

[pve-devel] [PATCH frr] add patch to change the starting order of mgmtd and zebra

[Hannes Duerr]

Currently the management daemon (mgmtd) starts only after Zebra is
started, which causes Zebra to throw some errors as described here [0].
Therefore we add a patch to change the starting order of the daemons.

Signed-off-by: Hannes Duerr <h.duerr@proxmox.com>
---

Notes:
    This patch was also send to upstream [0] and is still waiting to be
    applied
    
    [0] https://github.com/FRRouting/frr/pull/19209

 ...n-starting-order-for-debian-packages.patch | 35 +++++++++++++++++++
 debian/patches/series                         |  1 +
 2 files changed, 36 insertions(+)
 create mode 100644 debian/patches/pve/0007-tools-fix-daemon-starting-order-for-debian-packages.patch

diff --git a/debian/patches/pve/0007-tools-fix-daemon-starting-order-for-debian-packages.patch b/debian/patches/pve/0007-tools-fix-daemon-starting-order-for-debian-packages.patch
new file mode 100644
index 0000000..0f28d9a
--- /dev/null
+++ b/debian/patches/pve/0007-tools-fix-daemon-starting-order-for-debian-packages.patch
@@ -0,0 +1,35 @@
+From 800f336b0bfbe6bc932d438eac5ccce6ab7196e3 Mon Sep 17 00:00:00 2001
+From: Hannes Duerr <h.duerr@proxmox.com>
+Date: Wed, 16 Jul 2025 10:01:27 +0200
+Subject: [PATCH] tools: fix daemon starting order for debian packages
+
+Currently the management daemon (mgmtd) starts only after Zebra is
+started, which causes Zebra to throw some errors as described here [0].
+The problem is, when the MGMTD was introduced [1], the order in tools/frr.in
+was adjusted correctly, but not in tools/frrcommon.sh.in.
+We are therefore now also changing it in frrcommon.sh.in.
+
+[0] https://github.com/FRRouting/frr/issues/17931
+[1] https://github.com/FRRouting/frr/pull/13059/commits/1c84efe4fa8585df58a9b53459f94c47934f0786
+
+Signed-off-by: Hannes Duerr <h.duerr@proxmox.com>
+---
+ tools/frrcommon.sh.in | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/tools/frrcommon.sh.in b/tools/frrcommon.sh.in
+index 44355f8895..1848841aff 100755
+--- a/tools/frrcommon.sh.in
++++ b/tools/frrcommon.sh.in
+@@ -36,7 +36,7 @@ FRR_DEFAULT_PROFILE="@DFLT_NAME@" # traditional / datacenter
+ # - keep zebra first
+ # - watchfrr does NOT belong in this list
+ 
+-DAEMONS="zebra mgmtd bgpd ripd ripngd ospfd ospf6d isisd babeld pimd pim6d ldpd nhrpd eigrpd sharpd pbrd staticd bfdd fabricd vrrpd pathd"
++DAEMONS="mgmtd zebra bgpd ripd ripngd ospfd ospf6d isisd babeld pimd pim6d ldpd nhrpd eigrpd sharpd pbrd staticd bfdd fabricd vrrpd pathd"
+ RELOAD_SCRIPT="$D_PATH/frr-reload.py"
+ 
+ #
+-- 
+2.47.2
+
diff --git a/debian/patches/series b/debian/patches/series
index c59ef31..6e8863b 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -4,3 +4,4 @@ pve/0003-tests-add-bgp-evpn-autort-test.patch
 pve/0004-zebra-add-ZEBRA_IF_DUMMY-flag-for-dummy-interfaces.patch
 pve/0005-fabricd-add-option-to-treat-dummy-interfaces-as-loop.patch
 pve/0006-fabricd-enable-dummy_as_loopback-option-per-default.patch
+pve/0007-tools-fix-daemon-starting-order-for-debian-packages.patch
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH frr] add patch to change the starting order of mgmtd and zebra

[Thomas Lamprecht]

On Wed, 16 Jul 2025 11:30:10 +0200, Hannes Duerr wrote:
> Currently the management daemon (mgmtd) starts only after Zebra is
> started, which causes Zebra to throw some errors as described here [0].
> Therefore we add a patch to change the starting order of the daemons.
> 
> 

This seems straight forward and got already a positive review upstream, so:

Applied, thanks!

[1/1] add patch to change the starting order of mgmtd and zebra
      commit: 2b20228e696c839c3d9754b996244c9f4c1db8ee


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel