From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [pmg-devel] [PATCH proxmox] login: use 'PMG' as product for 'PMGQUAR' tickets
Date: Thu, 3 Jul 2025 09:49:37 +0200 [thread overview]
Message-ID: <175152897366.886589.10688130478475707980.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250625073844.609286-1-d.csapak@proxmox.com>
On Wed, 25 Jun 2025 09:38:44 +0200, Dominik Csapak wrote:
> We derive the product name from the beginning of the ticket normally,
> but this does not work with PMGQUAR tickets. Since the cookie name uses
> the product name, this results in a `PMGQUARAuthCookie`, but the cookie
> still has to be `PMGAuthCookie` to work. To work around that, decouple
> the userid range of the ticket from the product range, and modify it so
> that PMGQUAR tickets return also PMG for the product. This will result
> in the correct `PMGAuthCookie` name.
>
> [...]
The shared cookie name is IMO not so great here in the first place, but works
OK-ish enough for all that are just spam quarantine users, and no PMG admins
or the like too. Maybe we can look into a clean seperation here for the future,
but nothing all to important for now.
Applied, thanks!
[1/1] login: use 'PMG' as product for 'PMGQUAR' tickets
commit: 33f9c3a41ad95d2c885568a78b389579665fc959
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
WARNING: multiple messages have this Message-ID
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pmg-devel] applied: [PATCH proxmox] login: use 'PMG' as product for 'PMGQUAR' tickets
Date: Thu, 3 Jul 2025 09:49:37 +0200 [thread overview]
Message-ID: <175152897366.886589.10688130478475707980.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250625073844.609286-1-d.csapak@proxmox.com>
On Wed, 25 Jun 2025 09:38:44 +0200, Dominik Csapak wrote:
> We derive the product name from the beginning of the ticket normally,
> but this does not work with PMGQUAR tickets. Since the cookie name uses
> the product name, this results in a `PMGQUARAuthCookie`, but the cookie
> still has to be `PMGAuthCookie` to work. To work around that, decouple
> the userid range of the ticket from the product range, and modify it so
> that PMGQUAR tickets return also PMG for the product. This will result
> in the correct `PMGAuthCookie` name.
>
> [...]
The shared cookie name is IMO not so great here in the first place, but works
OK-ish enough for all that are just spam quarantine users, and no PMG admins
or the like too. Maybe we can look into a clean seperation here for the future,
but nothing all to important for now.
Applied, thanks!
[1/1] login: use 'PMG' as product for 'PMGQUAR' tickets
commit: 33f9c3a41ad95d2c885568a78b389579665fc959
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
next prev parent reply other threads:[~2025-07-03 7:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 7:38 Dominik Csapak
2025-07-03 7:49 ` Thomas Lamprecht [this message]
2025-07-03 7:49 ` [pmg-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175152897366.886589.10688130478475707980.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.