all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, pdm-devel@lists.proxmox.com,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pdm-devel] applied: [PATCH datacenter-manager] cli: fix adding remotes
Date: Tue,  1 Jul 2025 11:41:47 +0200	[thread overview]
Message-ID: <175136290290.4025787.4400514774616596334.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250616135804.3212548-1-d.csapak@proxmox.com>

On Mon, 16 Jun 2025 15:58:04 +0200, Dominik Csapak wrote:
> three things needed fixing here:
> * type is already included in the remote type, so no need to have it
>   externally
> * the api call uses `async` so change the handler matching
> * the api call needs the proxmox_product_config to be initialized
> 
> noticed by a user in the forum:
> https://forum.proxmox.com/threads/167483/
> 
> [...]

Applied, thanks!

[1/1] cli: fix adding remotes
      commit: a250bc6b054548994cf2d7c169579c6ce0bfc6f7


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


WARNING: multiple messages have this Message-ID
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, pdm-devel@lists.proxmox.com,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [pdm-devel] [PATCH datacenter-manager] cli: fix adding remotes
Date: Tue,  1 Jul 2025 11:41:47 +0200	[thread overview]
Message-ID: <175136290290.4025787.4400514774616596334.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250616135804.3212548-1-d.csapak@proxmox.com>

On Mon, 16 Jun 2025 15:58:04 +0200, Dominik Csapak wrote:
> three things needed fixing here:
> * type is already included in the remote type, so no need to have it
>   externally
> * the api call uses `async` so change the handler matching
> * the api call needs the proxmox_product_config to be initialized
> 
> noticed by a user in the forum:
> https://forum.proxmox.com/threads/167483/
> 
> [...]

Applied, thanks!

[1/1] cli: fix adding remotes
      commit: a250bc6b054548994cf2d7c169579c6ce0bfc6f7


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-07-01  9:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-16 13:58 [pdm-devel] " Dominik Csapak
2025-06-17 16:19 ` Michael Köppl
2025-07-01  9:41 ` Thomas Lamprecht [this message]
2025-07-01  9:41   ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175136290290.4025787.4400514774616596334.b4-ty@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal