From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Reiter <s.reiter@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] api: always add new CD drives to bootorder
Date: Fri, 23 Jul 2021 11:05:54 +0200 [thread overview]
Message-ID: <17451e51-c068-806a-505e-ebcf63609eab@proxmox.com> (raw)
In-Reply-To: <20210705091412.155198-1-s.reiter@proxmox.com>
On 05.07.21 11:14, Stefan Reiter wrote:
> Attaching an ISO image to a VM is usually/often done for two reasons:
> * booting an installer image
> * supplying additional drivers to an installer (e.g. virtio)
>
> Both of these cases (the latter at least with SeaBIOS and the Windows
> installer) require the disk to be marked as bootable.
>
> For this reason, enable the bootable flag for all new CDROM drives
> attached to a VM by adding it to the bootorder list. It is appended to
> the end, as otherwise it would cause new drives to boot before already
> existing boot targets, which would be a more grave (and IMO bad)
> behaviour change.
>
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
> PVE/API2/Qemu.pm | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>
applied, thanks!
prev parent reply other threads:[~2021-07-23 9:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 9:14 [pve-devel] " Stefan Reiter
2021-07-23 9:05 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17451e51-c068-806a-505e-ebcf63609eab@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.reiter@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.