all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: [pbs-devel] applied:  [PATCH proxmox] notify: clippy fixes
Date: Tue, 15 Apr 2025 12:27:18 +0200	[thread overview]
Message-ID: <1744712832.fhccxwjokm.astroid@yuna.none> (raw)
In-Reply-To: <20250410093038.124269-1-l.wagner@proxmox.com>

thanks!

On April 10, 2025 11:30 am, Lukas Wagner wrote:
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>  proxmox-notify/src/endpoints/webhook.rs | 2 +-
>  proxmox-notify/src/renderer/mod.rs      | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/proxmox-notify/src/endpoints/webhook.rs b/proxmox-notify/src/endpoints/webhook.rs
> index 604777c7..eada590e 100644
> --- a/proxmox-notify/src/endpoints/webhook.rs
> +++ b/proxmox-notify/src/endpoints/webhook.rs
> @@ -359,7 +359,7 @@ impl WebhookEndpoint {
>          //
>          // -> send the header always, unless we do a get with no body (which is the expected case
>          // for GET)
> -        let content_length = body.as_bytes().len();
> +        let content_length = body.len();
>          if !(self.config.method == HttpMethod::Get && content_length == 0) {
>              builder = builder.header(http::header::CONTENT_LENGTH, content_length);
>          }
> diff --git a/proxmox-notify/src/renderer/mod.rs b/proxmox-notify/src/renderer/mod.rs
> index b37cf438..bff76ed1 100644
> --- a/proxmox-notify/src/renderer/mod.rs
> +++ b/proxmox-notify/src/renderer/mod.rs
> @@ -285,7 +285,7 @@ fn render_template_impl(
>      filename: &str,
>      source: TemplateSource,
>  ) -> Result<Option<String>, Error> {
> -    let template_string = context::context().lookup_template(&filename, None, source)?;
> +    let template_string = context::context().lookup_template(filename, None, source)?;
>  
>      if let Some(template_string) = template_string {
>          let mut handlebars = Handlebars::new();
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


      reply	other threads:[~2025-04-15 10:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-10  9:30 [pbs-devel] " Lukas Wagner
2025-04-15 10:27 ` Fabian Grünbichler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1744712832.fhccxwjokm.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal