From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Stefan Hanreich <s.hanreich@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-network 1/1] ipam: netbox: fix adding vms without a name set in the options
Date: Tue, 8 Apr 2025 15:37:20 +0200 [thread overview]
Message-ID: <174411943163.4086013.12033672803790123435.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250408132517.225240-1-s.hanreich@proxmox.com>
On Tue, 08 Apr 2025 15:25:17 +0200, Stefan Hanreich wrote:
> The hostname provided to the methods in the IPAM plugins is empty for
> VMs that do not have a name set. We always included the dns_name key
> in the request, even if it was undefined, which leads Netbox to return
> a 400 Bad Request error. With this patch we omit the dns_name
> parameter if it isn't set, so the call succeeds.
>
>
> [...]
Applied, thanks!
[1/1] ipam: netbox: fix adding vms without a name set in the options
commit: 3ede261b255263ba79a63446305ba0a0f408592c
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-04-08 13:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-08 13:25 Stefan Hanreich
2025-04-08 13:29 ` Thomas Lamprecht
2025-04-08 13:32 ` Stefan Hanreich
2025-04-08 13:37 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174411943163.4086013.12033672803790123435.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal