all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer] common: options: use more sensible fallback values for network options
Date: Mon,  7 Apr 2025 18:31:59 +0200	[thread overview]
Message-ID: <174404350519.2976133.9929553225850884419.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250407154810.1565150-1-c.heiss@proxmox.com>

On Mon, 07 Apr 2025 17:47:47 +0200, Christoph Heiss wrote:
> When no DHCP server is configured on the network and/or no DHCP lease
> is received, the auto-installer falls back to Ipv4Addr::UNSPECIFIED -
> which resolves to `0.0.0.0/0` - for the interface address, gateway and
> DNS server. This is then written to /etc/network/interfaces and could
> cause further issues after the installation.
> 
> At the same time, this also means that no interface name will be set,
> which causes the low-level installer to write out an invalid
> /etc/network/interfaces entry.
> 
> [...]

Applied, thanks!

[1/1] common: options: use more sensible fallback values for network options
      commit: ec5096be3dd974ffd79c7368a44a3ffbd2feb8a0


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2025-04-07 16:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07 15:47 [pve-devel] " Christoph Heiss
2025-04-07 16:31 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=174404350519.2976133.9929553225850884419.b4-ty@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal