From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Stefan Hanreich <s.hanreich@proxmox.com>
Subject: Re: [pve-devel] [PATCH proxmox-ve-rs 1/3] firewall macros: fix macros using icmp protocol
Date: Mon, 7 Apr 2025 13:51:39 +0200 [thread overview]
Message-ID: <174402640321.2717813.473511199622569529.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250204095733.55146-1-s.hanreich@proxmox.com>
On Tue, 04 Feb 2025 10:57:31 +0100, Stefan Hanreich wrote:
> Macros containing rules for the ICMP protocol used dport instead of
> icmp-type for specifying the type of ICMP messages. This is how
> pve-firewall used to specify them, but the nftables firewall uses a
> separate key for this in the macros. This caused all ICMP types to be
> allowed instead of restricting them to the types specified in the
> macro.
>
> [...]
Applied, thanks!
[1/3] firewall macros: fix macros using icmp protocol
commit: 2a32eee42fa3fa90616666477cdbf3da5cbfae8f
[2/3] fix #6108: firewall macros: Add missing ICMPv6 statements
commit: 8f2f3c62954d4052cd08a56993cf006773e760af
[3/3] tests: add Ping macro to tests
commit: 75d2c9793c49a5e030d68237a1734d6c922e80cf
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-04-07 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 9:57 Stefan Hanreich
2025-02-04 9:57 ` [pve-devel] [PATCH proxmox-ve-rs 2/3] fix #6108: firewall macros: Add missing ICMPv6 statements Stefan Hanreich
2025-02-04 9:57 ` [pve-devel] [PATCH proxmox-firewall 3/3] tests: add Ping macro to tests Stefan Hanreich
2025-03-13 15:04 ` Hannes Laimer
2025-04-07 11:51 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174402640321.2717813.473511199622569529.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal