From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Christoph Heiss <c.heiss@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v2 1/2] window: migrate: make all user-visible strings translatable
Date: Mon, 7 Apr 2025 12:06:27 +0200 [thread overview]
Message-ID: <174401995303.2626354.5380020422632639795.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250407091647.202800-1-c.heiss@proxmox.com>
On Mon, 07 Apr 2025 11:16:27 +0200, Christoph Heiss wrote:
> Quite a few user-visible strings in the dialog currently are not using
> gettext(), thus not making them translatable.
>
> While at it, also remove some contractions from error/warning messages.
> Not strictly necessary per our style guide, but it avoids escaping
> single quotes and reads quite a bit nicer IMHO.
>
> [...]
Applied, fixed the subject to start with a `ui` tag and then
use a slightly more verbose `guest migrate window` second
level tag, thanks!
[1/2] ui: guest migrate window: make all user-visible strings translatable
commit: 5c8e6e5a6e97f418452196642bcdcacfbd68bb25
[2/2] ui: guest migrate window: use predefined constant for error alert title
commit: 29e53e5f46b2e4015fda12375668ead019c27902
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-04-07 10:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 9:16 Christoph Heiss
2025-04-07 9:16 ` [pve-devel] [PATCH manager v2 2/2] window: migrate: use predefined constant for error alert title Christoph Heiss
2025-04-07 10:06 ` Thomas Lamprecht [this message]
2025-04-07 10:49 ` [pve-devel] [PATCH manager v2 1/2] window: migrate: make all user-visible strings translatable Christoph Heiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174401995303.2626354.5380020422632639795.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal