From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: pve-devel@lists.proxmox.com, Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH-SERIES v2 storage 0/5] unsized subvol regression fix and improvements
Date: Sun, 6 Apr 2025 21:59:12 +0200 [thread overview]
Message-ID: <174396953020.1900884.15790130159681678128.b4-ty@proxmox.com> (raw)
In-Reply-To: <20250303092445.13873-1-f.ebner@proxmox.com>
On Mon, 03 Mar 2025 10:24:40 +0100, Fiona Ebner wrote:
> Changes in v2:
> * comment out dead code in BTRFS plugin
> * improve commit messages regarding clone
> * squash patches 5/6 and 6/6 from v1
>
> In list context, the file_size_info() function in Plugin.pm and the
> volume_size_info() function in BTRFSPlugin.pm would return 0 for the
> size, but in scalar context 1. As reported in the community forum [0],
> the change in commit e50dde0 ("volume export: rely on storage plugin's
> format"), changing the caller in volume_export() to scalar context
> exposed the inconsistency in the return value for the size. This led
> to breakage of migration with unsized btrfs subvolumes.
>
> [...]
Applied, thanks!
[1/5] plugin: file size info: be consistent about size of directory subvol
commit: 544dc0e893549c62665991b58675fb71f4fe5aac
[2/5] btrfs: fix volume size info for subvolumes in scalar context
commit: 00105c8003aca8ba6499a4fbdd3803529e4671de
[3/5] plugin: volume export formats: avoid superfluous file_size_info() call
commit: d97d7ff676dae13ff6dc796103bbc2ef7f32f9e7
[4/5] api: volume info: do not fail for zero-sized subvolumes
commit: 0426aa316598f329eacaf80e24638294e746c1be
[5/5] btrfs: die early for broken subvolume resize
commit: 5a73bac3439261da4b39c6ad22bd32d0ff19b2e6
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-04-06 19:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 9:24 [pve-devel] " Fiona Ebner
2025-03-03 9:24 ` [pve-devel] [PATCH v2 storage 1/5] plugin: file size info: be consistent about size of directory subvol Fiona Ebner
2025-03-03 9:24 ` [pve-devel] [PATCH v2 storage 2/5] btrfs: fix volume size info for subvolumes in scalar context Fiona Ebner
2025-03-03 9:24 ` [pve-devel] [PATCH v2 storage 3/5] plugin: volume export formats: avoid superfluous file_size_info() call Fiona Ebner
2025-03-03 9:24 ` [pve-devel] [PATCH v2 storage 4/5] api: volume info: do not fail for zero-sized subvolumes Fiona Ebner
2025-03-03 9:24 ` [pve-devel] [PATCH v2 storage 5/5] btrfs: die early for broken subvolume resize Fiona Ebner
2025-04-06 19:59 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174396953020.1900884.15790130159681678128.b4-ty@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal