all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: [pbs-devel] applied: [PATCH v3 proxmox-backup 3/9] datastore: use libc's timespec constants instead of redefinition
Date: Wed, 05 Mar 2025 10:41:32 +0100	[thread overview]
Message-ID: <1741165277.s9t9jfl3wk.astroid@yuna.none> (raw)
In-Reply-To: <20250304183546.461918-4-c.ebner@proxmox.com>

applied this one already :)

On March 4, 2025 7:35 pm, Christian Ebner wrote:
> Use the UTIME_NOW and UTIME_OMIT constants defined in libc crate
> instead of redefining them. This improves consistency, as utimesat
> and its timespec parameter are also defined via the libc crate.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> changes since version 2:
> - use libc's constants instead of re-defining them
> 
>  pbs-datastore/src/chunk_store.rs | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/pbs-datastore/src/chunk_store.rs b/pbs-datastore/src/chunk_store.rs
> index 29d5874a1..5e02909a1 100644
> --- a/pbs-datastore/src/chunk_store.rs
> +++ b/pbs-datastore/src/chunk_store.rs
> @@ -220,19 +220,16 @@ impl ChunkStore {
>          // unwrap: only `None` in unit tests
>          assert!(self.locker.is_some());
>  
> -        const UTIME_NOW: i64 = (1 << 30) - 1;
> -        const UTIME_OMIT: i64 = (1 << 30) - 2;
> -
>          let times: [libc::timespec; 2] = [
>              // access time -> update to now
>              libc::timespec {
>                  tv_sec: 0,
> -                tv_nsec: UTIME_NOW,
> +                tv_nsec: libc::UTIME_NOW,
>              },
>              // modification time -> keep as is
>              libc::timespec {
>                  tv_sec: 0,
> -                tv_nsec: UTIME_OMIT,
> +                tv_nsec: libc::UTIME_OMIT,
>              },
>          ];
>  
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  reply	other threads:[~2025-03-05  9:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-04 18:35 [pbs-devel] [PATCH v3 proxmox-backup 0/9] fix #5982: check atime update is honored Christian Ebner
2025-03-04 18:35 ` [pbs-devel] [PATCH v3 proxmox 1/2] pbs api types: add garbage collection atime safety check flag Christian Ebner
2025-03-04 18:35 ` [pbs-devel] [PATCH v3 proxmox 2/2] pbs api types: add option to set GC chunk cleanup atime cutoff Christian Ebner
2025-03-04 18:35 ` [pbs-devel] [PATCH v3 proxmox-backup 3/9] datastore: use libc's timespec constants instead of redefinition Christian Ebner
2025-03-05  9:41   ` Fabian Grünbichler [this message]
2025-03-04 18:35 ` [pbs-devel] [PATCH v3 proxmox-backup 4/9] fix #5982: garbage collection: check atime updates are honored Christian Ebner
2025-03-05  9:41   ` Fabian Grünbichler
2025-03-05 10:31     ` Christian Ebner
2025-03-05  9:41   ` Fabian Grünbichler
2025-03-04 18:35 ` [pbs-devel] [PATCH v3 proxmox-backup 5/9] ui: expose GC atime safety check flag in datastore tuning options Christian Ebner
2025-03-04 18:35 ` [pbs-devel] [PATCH v3 proxmox-backup 6/9] docs: mention GC atime update check for " Christian Ebner
2025-03-04 18:35 ` [pbs-devel] [PATCH v3 proxmox-backup 7/9] datastore: conditionally use custom GC atime cutoff if set Christian Ebner
2025-03-05  9:41   ` Fabian Grünbichler
2025-03-04 18:35 ` [pbs-devel] [PATCH v3 proxmox-backup 8/9] ui: expose GC atime cutoff in datastore tuning option Christian Ebner
2025-03-04 18:35 ` [pbs-devel] [PATCH v3 proxmox-backup 9/9] docs: mention gc-atime-cutoff as " Christian Ebner
2025-03-05  9:41 ` [pbs-devel] [PATCH v3 proxmox-backup 0/9] fix #5982: check atime update is honored Fabian Grünbichler
2025-03-05 15:17 ` Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1741165277.s9t9jfl3wk.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal