* [pve-devel] [PATCH v2 manager] fix #3037: include the split_list to shell_qoute
@ 2023-01-23 9:52 Moayad Almalat
2023-01-25 8:38 ` [pve-devel] applied: " Wolfgang Bumiller
0 siblings, 1 reply; 4+ messages in thread
From: Moayad Almalat @ 2023-01-23 9:52 UTC (permalink / raw)
To: pve-devel
Based to the suggestion of Wolfgang, in regard to `split_list()`,
I converted the `split_list()` to `split(/\0/, $param->{$key});`
this will split the `$param->{$key}` null characters and push each
element to the `$args` array along with the key value.
changes since v1:
* get rid of the `use PVE::Tools qw(split_list);` since not need it anymore.
* replace the split_list to split(/\0/).
Signed-off-by: Moayad Almalat <m.almalat@proxmox.com>
---
PVE/CLI/pvesh.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/CLI/pvesh.pm b/PVE/CLI/pvesh.pm
index 370fdb0e..9acf292a 100755
--- a/PVE/CLI/pvesh.pm
+++ b/PVE/CLI/pvesh.pm
@@ -106,7 +106,7 @@ sub proxy_handler {
my $args = [];
foreach my $key (keys %$param) {
next if $key eq 'quiet' || $key eq 'output-format'; # just to be sure
- push @$args, "--$key", $param->{$key};
+ push @$args, "--$key", $_ for split(/\0/, $param->{$key});
}
my $remcmd = ['ssh', '-o', 'BatchMode=yes', "root\@$remip",
--
2.30.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] applied: [PATCH v2 manager] fix #3037: include the split_list to shell_qoute
2023-01-23 9:52 [pve-devel] [PATCH v2 manager] fix #3037: include the split_list to shell_qoute Moayad Almalat
@ 2023-01-25 8:38 ` Wolfgang Bumiller
2023-01-25 8:59 ` Thomas Lamprecht
0 siblings, 1 reply; 4+ messages in thread
From: Wolfgang Bumiller @ 2023-01-25 8:38 UTC (permalink / raw)
To: Moayad Almalat; +Cc: pve-devel
applied
Though the whole commit message is actually the change log to v1 of the
patch and should not have mentioned the `split_list` part at all, only
what it actually does and the change list should go below the `---`,
please separate these things in the future.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pve-devel] applied: [PATCH v2 manager] fix #3037: include the split_list to shell_qoute
2023-01-25 8:38 ` [pve-devel] applied: " Wolfgang Bumiller
@ 2023-01-25 8:59 ` Thomas Lamprecht
2023-01-25 9:30 ` Wolfgang Bumiller
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Lamprecht @ 2023-01-25 8:59 UTC (permalink / raw)
To: Proxmox VE development discussion, Wolfgang Bumiller, Moayad Almalat
Am 25/01/2023 um 09:38 schrieb Wolfgang Bumiller:
> applied
>
> Though the whole commit message is actually the change log to v1 of the
> patch and should not have mentioned the `split_list` part at all, only
> what it actually does and the change list should go below the `---`,
> please separate these things in the future.
>
but you also applied it as is? I.e., outdated and far from helpful for
extracting and actual useful d/changelog entry.
please either amend commit messages on applying, if they're wrong, outdated,
..., otherwise reject the patch on that ground.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pve-devel] applied: [PATCH v2 manager] fix #3037: include the split_list to shell_qoute
2023-01-25 8:59 ` Thomas Lamprecht
@ 2023-01-25 9:30 ` Wolfgang Bumiller
0 siblings, 0 replies; 4+ messages in thread
From: Wolfgang Bumiller @ 2023-01-25 9:30 UTC (permalink / raw)
To: Thomas Lamprecht, Proxmox VE development discussion, Moayad Almalat
> On 01/25/2023 9:59 AM CET Thomas Lamprecht <t.lamprecht@proxmox.com> wrote:
>
>
> Am 25/01/2023 um 09:38 schrieb Wolfgang Bumiller:
> > applied
> >
> > Though the whole commit message is actually the change log to v1 of the
> > patch and should not have mentioned the `split_list` part at all, only
> > what it actually does and the change list should go below the `---`,
> > please separate these things in the future.
> >
>
> but you also applied it as is? I.e., outdated and far from helpful for
> extracting and actual useful d/changelog entry.
>
> please either amend commit messages on applying, if they're wrong, outdated,
> ..., otherwise reject the patch on that ground.
Yeah sorry about that.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-25 9:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-23 9:52 [pve-devel] [PATCH v2 manager] fix #3037: include the split_list to shell_qoute Moayad Almalat
2023-01-25 8:38 ` [pve-devel] applied: " Wolfgang Bumiller
2023-01-25 8:59 ` Thomas Lamprecht
2023-01-25 9:30 ` Wolfgang Bumiller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal