From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] ui: utils: add task description for mounting/unmounting
Date: Tue, 26 Nov 2024 11:39:42 +0100 [thread overview]
Message-ID: <1732617544.qdqoqeoh5f.astroid@yuna.none> (raw)
In-Reply-To: <20241126101545.1105047-1-d.csapak@proxmox.com>
On November 26, 2024 11:15 am, Dominik Csapak wrote:
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/Utils.js | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/www/Utils.js b/www/Utils.js
> index 6bae9b709..484c607bd 100644
> --- a/www/Utils.js
> +++ b/www/Utils.js
> @@ -417,6 +417,7 @@ Ext.define('PBS.Utils', {
> 'label-media': [gettext('Drive'), gettext('Label Media')],
> 'load-media': (type, id) => PBS.Utils.render_drive_load_media_id(id, gettext('Load Media')),
> logrotate: [null, gettext('Log Rotation')],
> + 'mount-device': [gettext('Datastore'), gettext('Mount Device')],
> prune: (type, id) => PBS.Utils.render_datastore_worker_id(id, gettext('Prune')),
> prunejob: (type, id) => PBS.Utils.render_prune_job_worker_id(id, gettext('Prune Job')),
> reader: (type, id) => PBS.Utils.render_datastore_worker_id(id, gettext('Read Objects')),
> @@ -427,6 +428,7 @@ Ext.define('PBS.Utils', {
> 'tape-backup-job': (type, id) => PBS.Utils.render_tape_backup_id(id, gettext('Tape Backup Job')),
> 'tape-restore': ['Datastore', gettext('Tape Restore')],
> 'unload-media': [gettext('Drive'), gettext('Unload Media')],
> + 'unmount-device': [gettext('Datastore'), gettext('Un-mount Device')],
nit: I'd prefer "Unmount" instead of "Un-mount". we don't have a single
"Un-" in the whole codebase AFAICT ;)
> verificationjob: [gettext('Verify Job'), gettext('Scheduled Verification')],
> verify: ['Datastore', gettext('Verification')],
> verify_group: ['Group', gettext('Verification')],
> --
> 2.39.5
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-11-26 10:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 10:15 Dominik Csapak
2024-11-26 10:39 ` Fabian Grünbichler [this message]
2024-11-26 10:46 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1732617544.qdqoqeoh5f.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.