From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Gabriel Goller <g.goller@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup v2] reuse-datastore: avoid creating another default prune job
Date: Mon, 25 Nov 2024 15:37:01 +0100 [thread overview]
Message-ID: <1732545364.j7koj2vyxl.astroid@yuna.none> (raw)
In-Reply-To: <e9d86aa4-3652-4b23-ad81-5c0aa959e6e3@proxmox.com>
On November 25, 2024 11:10 am, Christian Ebner wrote:
> On 11/25/24 09:59, Gabriel Goller wrote:
>> If a datastore with a default prune job is removed, the prune job is
>> preserverd as it is stored in /etc/proxmox-backup/prune.cfg. We also
>> create a default prune job for every datastore – this means that when
>> reusing a datastore that previously existed, you end up with duplicate
>> prune jobs.
>
> Looking at this once more, I am not so sure anymore that this should
> only check for the default prune job? Why not check if there is any
> prune job configured at all for this datastore, and only if there is
> none create the new default prune job?
that would also work?
- if no prune job exists for this store, create default one
- if explicit prune job options where given, create that one
- otherwise, don't add a prune job (no options given, and one exists
already for this store)
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-11-25 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 8:59 Gabriel Goller
2024-11-25 10:10 ` Christian Ebner
2024-11-25 14:37 ` Fabian Grünbichler [this message]
2024-11-25 16:57 ` Gabriel Goller
2024-11-25 17:10 ` Gabriel Goller
2024-11-26 8:09 ` Fabian Grünbichler
2024-11-26 9:51 ` Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1732545364.j7koj2vyxl.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.