From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH v2 proxmox-backup 0/5] fix #5853: ignore stale files
Date: Thu, 21 Nov 2024 13:25:15 +0100 [thread overview]
Message-ID: <1732191900.4xn1zu55fm.astroid@yuna.none> (raw)
In-Reply-To: <20241114144114.375987-1-c.ebner@proxmox.com>
thanks! this version looks much cleaner now :)
On November 14, 2024 3:41 pm, Christian Ebner wrote:
> When files and their associated metadata get invalidated, I/O
> operations on network filesystems return ESTALE to indicate that the
> filehandle does not reference a valid file anymore.
>
> Currently, the proxmox-backup-client does not cover such cases, it
> will fail with a hard error when a stale file handle is encountered.
> Any concurrent operation invalidating file handles has the potential
> to lead to the backups failing if timed accordingly. For local
> filesystems this is not an issue, as the file remains accessible
> until the file handle is closed.
>
> Make the backup client more resilient by handling the ESTALE errors
> gracefully, warning the user about the vanished/invalidated files,
> while generating a valid and consistent backup archive nevertheless.
>
> Changes since version 1:
> - Avoid tuples in return values by downcasting anyhow::Error to Errno
> when latter is required
> - Add report stale file handle helper
> - Refactor report vanished/changed file helpers
>
> Christian Ebner (5):
> client: pxar: refactor report vanished/changed helpers
> client: pxar: skip directories on stale file handle
> client: pxar: skip directory entries on stale file handle
> client: pxar: warn user and ignore stale file handles on file open
> fix #5853: client: pxar: exclude stale files on metadata/link read
>
> pbs-client/src/pxar/create.rs | 94 +++++++++++++++++++++++++----------
> 1 file changed, 69 insertions(+), 25 deletions(-)
>
> --
> 2.39.5
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-11-21 12:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 14:41 [pbs-devel] " Christian Ebner
2024-11-14 14:41 ` [pbs-devel] [PATCH v2 proxmox-backup 1/5] client: pxar: refactor report vanished/changed helpers Christian Ebner
2024-11-14 14:41 ` [pbs-devel] [PATCH v2 proxmox-backup 2/5] client: pxar: skip directories on stale file handle Christian Ebner
2024-11-14 14:41 ` [pbs-devel] [PATCH v2 proxmox-backup 3/5] client: pxar: skip directory entries " Christian Ebner
2024-11-14 14:41 ` [pbs-devel] [PATCH v2 proxmox-backup 4/5] client: pxar: warn user and ignore stale file handles on file open Christian Ebner
2024-11-14 14:41 ` [pbs-devel] [PATCH v2 proxmox-backup 5/5] fix #5853: client: pxar: exclude stale files on metadata/link read Christian Ebner
2024-11-21 12:25 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1732191900.4xn1zu55fm.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.