Re: [pbs-devel] [PATCH proxmox-backup 3/4] client: pxar: warn user and ignore stale file handles on file open

["Fabian Grünbichler" <f.gruenbichler@proxmox.com>]

On November 5, 2024 3:01 pm, Christian Ebner wrote:
> Do not fail hard if a file open fails because of a stale file handle.
> Warn the user and ignore the file, just like the client already does
> in case of missing privileges to access the file.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>  pbs-client/src/pxar/create.rs | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/pbs-client/src/pxar/create.rs b/pbs-client/src/pxar/create.rs
> index 8685e8d42..2a844922c 100644
> --- a/pbs-client/src/pxar/create.rs
> +++ b/pbs-client/src/pxar/create.rs
> @@ -484,6 +484,10 @@ impl Archiver {
>                      log::warn!("failed to open file: {:?}: access denied", file_name);
>                      Ok(None)
>                  }
> +                Err(Errno::ESTALE) => {
> +                    log::warn!("failed to open file: {file_name:?}: stale file handle");
> +                    Ok(None)
> +                }

should we add a report_stale_file in vain of the other report helpers,
and use that in places where `self.path` contains the right information?

>                  Err(Errno::EPERM) if !noatime.is_empty() => {
>                      // Retry without O_NOATIME:
>                      noatime = OFlag::empty();
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel