Re: [pbs-devel] [PATCH proxmox-backup 2/3] sync: pull: do not resync currently newest snapshot on target

["Fabian Grünbichler" <f.gruenbichler@proxmox.com>]

On November 4, 2024 11:58 am, Christian Ebner wrote:
> The currently newest snapshot of a group on the sync target is not
> excluded from the list of already synced snapshots, leading to a
> re-sync.

this is intentional, the last snapshot might not have been completely
done on the source side when we last synced it (e.g., backup log still
missing, post-backup verification not done yet, ..).

> 
> Filter out the snapshot as well.
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> Might be ignored if the re-sync is intetional.
> 
> Implementation already present since commit:
> de8ec041 ("src/api2/sync.rs: implement remote sync")
> 
>  src/server/pull.rs | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/server/pull.rs b/src/server/pull.rs
> index cc1427196..7aa191d96 100644
> --- a/src/server/pull.rs
> +++ b/src/server/pull.rs
> @@ -528,7 +528,7 @@ async fn pull_group(
>          .enumerate()
>          .filter(|&(pos, ref dir)| {
>              source_snapshots.insert(dir.time);
> -            if last_sync_time > dir.time {
> +            if last_sync_time >= dir.time {
>                  already_synced_skip_info.update(dir.time);
>                  return false;
>              } else if already_synced_skip_info.count > 0 {
> @@ -536,7 +536,7 @@ async fn pull_group(
>                  already_synced_skip_info.reset();
>              }
>  
> -            if pos < cutoff && last_sync_time != dir.time {
> +            if pos < cutoff {
>                  transfer_last_skip_info.update(dir.time);
>                  return false;
>              } else if transfer_last_skip_info.count > 0 {
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel