Re: [pbs-devel] [PATCH vma-to-pbs v3 0/6] add support for bulk import of a dump directory

["Fabian Grünbichler" <f.gruenbichler@proxmox.com>]

this is shaping up nicely, some comments on individual patches.

I just bumped proxmox-backup-qemu and vma-to-pbs to use PBS 3.2.8-1, please
rebase on top of that for subsequent versions.

Quoting Filip Schauer (2024-10-22 16:28:37)
> When a path to a directory is provided in the vma_file argument, try to
> upload all VMA backups in the directory. This also handles compressed
> VMA files, notes and logs. If a vmid is specified with --vmid, only the
> backups of that particular vmid are uploaded.
> 
> Also improve the readability of the log messages to keep track of all
> imported backups.
> 
> Changed since v2:
> * Make skipping a VMID on error optional with the --skip-failed option
> * Switch log output from stderr to stdout
> * Bump itertools to 0.13
> 
> Changed since v1:
> * Do not recurse through dump directory
> * Compile regex once before iterating over the files in the dump
>   directory
> * Use extract on regex capture groups
> * Do not use deprecated method `chrono::NaiveDateTime::timestamp`
> * Use proxmox_sys::fs::file_read_optional_string
> * Group VMA files by VMID and continue with next VMID on error
> * Move the BackupVmaToPbsArgs split into its own commit
> * Remove hard coded occurences of 255
> * Use level-based logging instead of println
> 
> Filip Schauer (6):
>   split BackupVmaToPbsArgs into PbsArgs and VmaBackupArgs
>   add support for bulk import of a dump directory
>   add option to skip vmids whose backups failed to upload
>   remove hard coded values
>   use level-based logging instead of println
>   log device upload progress as a percentage
> 
>  Cargo.toml     |   5 +
>  src/main.rs    | 156 ++++++++++++++++++++++---
>  src/vma.rs     |   2 +-
>  src/vma2pbs.rs | 312 ++++++++++++++++++++++++++++++++-----------------
>  4 files changed, 354 insertions(+), 121 deletions(-)
> 
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
>


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel