From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] build: fix `nocheck` build
Date: Thu, 27 Jun 2024 09:26:40 +0200 [thread overview]
Message-ID: <1719473192.b6bk3m444a.astroid@yuna.none> (raw)
In-Reply-To: <20240603120450.1135763-1-f.gruenbichler@proxmox.com>
since I ran into this again..
On June 3, 2024 2:04 pm, Fabian Grünbichler wrote:
> pbs2to3 was missing from the list of to-be-compiled binaries, and thus was only
> compiled as a side-effect of running `cargo test` (which is skipped when the
> build is using the `nocheck` build profile).
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> the whole COMPILED_BINS handling seems a bit incomplete, should we also add
> pbs2to3 and docgen/dump-catalog-shell-cli to it?
>
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index 03e938767..3e2341864 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -176,6 +176,7 @@ $(COMPILED_BINS) $(COMPILEDIR)/dump-catalog-shell-cli $(COMPILEDIR)/docgen: .do-
> --bin proxmox-restore-daemon \
> --package proxmox-backup \
> --bin docgen \
> + --bin pbs2to3 \
> --bin proxmox-backup-api \
> --bin proxmox-backup-manager \
> --bin proxmox-backup-proxy \
> --
> 2.39.2
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-06-27 7:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 12:04 [pbs-devel] " Fabian Grünbichler
2024-06-27 7:26 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1719473192.b6bk3m444a.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.