all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: [pbs-devel] partially-applied: [PATCH v3 pxar proxmox-backp 0/6] fix fuse mount performance for split archives
Date: Wed, 12 Jun 2024 11:27:57 +0200	[thread overview]
Message-ID: <1718184441.joh1dk4s22.astroid@yuna.none> (raw)
In-Reply-To: <20240612082400.110789-1-c.ebner@proxmox.com>

applied pxar patches 1, 2 and 4, and added some feedback on 3 that
affects the rest

On June 12, 2024 10:23 am, Christian Ebner wrote:
> Fuse mounts for split pxar archives currently greatly suffer from the
> consistency check between metadata and payload data archives, as
> these happen already during decoding of the payload reference entry
> in the metadata archive. By moving this check to the content reader
> instantiation, the performance can be improved significantly, as now
> the payload data chunks only need to be fetched and decoded when
> actually accessing the file payloads.
> 
> Changes since version 2:
> - Make helper and ContentRange pub(crate) only
> - Fix typo in commit message
> - Move incorrectly squashed cargo fmt patch into own patch
> 
> Changes since version 1:
> - Add previously missing check when accessing contents via the accessor
>   instead of the decoder.
> - Add missing context and refactor file entry extraction branch in pxar
>   extract according to suggestions
> 
> pxar:
> 
> Christian Ebner (5):
>   accessor: fix minor formatting issue
>   format: add helper for payload header consistency checks
>   format: add helper type ContentRange
>   decoder: move payload header check for split input
>   accessor: add payload checks for split archives
> 
>  src/accessor/aio.rs  | 15 ++++++-----
>  src/accessor/mod.rs  | 60 +++++++++++++++++++++++++++++++++-----------
>  src/accessor/sync.rs | 16 ++++++------
>  src/decoder/aio.rs   |  4 +--
>  src/decoder/mod.rs   | 56 +++++++++++++++++++++++------------------
>  src/decoder/sync.rs  |  5 ++--
>  src/format/mod.rs    | 32 +++++++++++++++++++++++
>  7 files changed, 132 insertions(+), 56 deletions(-)
> 
> promxox-backup:
> 
> Christian Ebner (1):
>   client: pxar: fix fuse mount performance for split archives
> 
>  pbs-client/src/pxar/extract.rs | 62 ++++++++++++++++------------------
>  pbs-pxar-fuse/src/lib.rs       | 14 ++++----
>  src/api2/tape/restore.rs       |  2 +-
>  3 files changed, 37 insertions(+), 41 deletions(-)
> 
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  parent reply	other threads:[~2024-06-12  9:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-12  8:23 [pbs-devel] " Christian Ebner
2024-06-12  8:23 ` [pbs-devel] [PATCH v3 pxar 1/6] accessor: fix minor formatting issue Christian Ebner
2024-06-12  8:23 ` [pbs-devel] [PATCH v3 pxar 2/6] format: add helper for payload header consistency checks Christian Ebner
2024-06-12  8:23 ` [pbs-devel] [PATCH v3 pxar 3/6] format: add helper type ContentRange Christian Ebner
2024-06-12  9:27   ` Fabian Grünbichler
     [not found]     ` <CAFtnzVcG1CFUhs9WiePBLuDKihHQM8mOiuJKKjhFy+rmuxY4pw@mail.gmail.com>
2024-06-12 11:47       ` Fabian Grünbichler
2024-06-12 11:50     ` Christian Ebner
2024-06-12  8:23 ` [pbs-devel] [PATCH v3 pxar 4/6] decoder: move payload header check for split input Christian Ebner
2024-06-12  8:23 ` [pbs-devel] [PATCH v3 pxar 5/6] accessor: add payload checks for split archives Christian Ebner
2024-06-12  8:24 ` [pbs-devel] [PATCH v3 proxmox-backup 6/6] client: pxar: fix fuse mount performance " Christian Ebner
2024-06-12  9:27 ` Fabian Grünbichler [this message]
2024-06-12 13:18 ` [pbs-devel] [PATCH v3 pxar proxmox-backp 0/6] " Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1718184441.joh1dk4s22.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal