Re: [pve-devel] [PATCH v2 pve-guest-common pve-container pve-manager 0/4] change-detection-mode for PBS

["Fabian Grünbichler" <f.gruenbichler@proxmox.com>]

Reviewed-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>

with one slight caveat - I'd like to change the "Default" enum value in
PBS to something else "V1", "Legacy", .., which has some consequences
here, so I held off applying this for now..

On May 29, 2024 2:07 pm, Christian Ebner wrote:
> This patch series defines the vzdump configuration description as well
> as backup job configuration option in the WebUI to set the
> experimental `change-detection-mode` parameter to the
> proxmox-backup-client invocation for container backups having a Proxmox
> Backup Server storage target.
> 
> This allows to either set the parameter to the node wide vzdump.conf
> or on a per job level. The following shows an exemplary job
> configuration taken from /etc/pve/jobs.cfg:
> 
> ```
> vzdump: backup-ab2edf62-d43c
> 	schedule yearly
> 	compress zstd
> 	enabled 1
> 	fleecing 0
> 	mode snapshot
> 	notes-template {{guestname}}
> 	pbs-change-detection-mode metadata
> 	storage pbs-local
> 	vmid 100
> ```
> 
> This patches depend on a proxmox-backup-client compiled with the
> following patch series applied:
> https://lists.proxmox.com/pipermail/pbs-devel/2024-May/009526.html
> 
> pve-guest-common:
> 
> Christian Ebner (1):
>   vzdump: add PBS change detection mode configuration
> 
>  src/PVE/VZDump/Common.pm | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> pve-container:
> 
> Christian Ebner (1):
>   vzdump: conditionally set PBS change detection mode option
> 
>  src/PVE/VZDump/LXC.pm | 2 ++
>  1 file changed, 2 insertions(+)
> 
> pve-manager:
> 
> Christian Ebner (2):
>   www: advanced backup: add pbs change detection mode selector
>   vzdump: add pbs-change-detection-mode to config template
> 
>  configs/vzdump.conf                         |  1 +
>  www/manager6/panel/BackupAdvancedOptions.js | 20 ++++++++++++++++++++
>  2 files changed, 21 insertions(+)
> 
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 
> 


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel