From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup 0/2] conditionally skip pxar metadata reference test
Date: Thu, 06 Jun 2024 10:54:54 +0200 [thread overview]
Message-ID: <1717664084.39cw3pfyah.astroid@yuna.none> (raw)
In-Reply-To: <20240606081711.91531-1-c.ebner@proxmox.com>
thanks!
On June 6, 2024 10:17 am, Christian Ebner wrote:
> When running as user with uid/gid not equal to 1000/1000, the test to
> create a pxar archive with previous metadata reference would fail, as
> the created test directories and files do not get the expected ownership
> set because of lack of permissions.
>
> Therefore these patches do:
> - not even attempt to set the uid/gid for the folders, as without
> permissions these are not set anyways.
> - only execute the test on the condition that euid and egid are 1000
>
> Tested by running the tests via:
> `cargo test --workspace --release -- --nocapture`
>
> For root user and user with uid/gid 1000. Without the patches the test
> fails for the root user, with the patches applied it passes for both.
>
> Christian Ebner (2):
> client: pxar: do not attempt to set uid/gid in test
> client: pxar: conditionally skip metadata reference test
>
> pbs-client/src/pxar/create.rs | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> --
> 2.39.2
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-06-06 8:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 8:17 [pbs-devel] " Christian Ebner
2024-06-06 8:17 ` [pbs-devel] [PATCH proxmox-backup 1/2] client: pxar: do not attempt to set uid/gid in test Christian Ebner
2024-06-06 8:17 ` [pbs-devel] [PATCH proxmox-backup 2/2] client: pxar: conditionally skip metadata reference test Christian Ebner
2024-06-06 8:54 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1717664084.39cw3pfyah.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.