Re: [pbs-devel] [PATCH proxmox-backup] fix #5439: disallow creation of datastore in root

["Fabian Grünbichler" <f.gruenbichler@proxmox.com>]

On May 10, 2024 11:58 am, Gabriel Goller wrote:
> Creating a datastore in root ('/') works, but afterwards gc fails (can't
> traverse all directories). It might be sensible to restrict this and
> disallow creation of datastores in the root directory.

if we do this, we should also forbid it on the frontend side ;)

I wonder whether we shouldn't handle this in a more generic fashion
though:
- disallow path being non-empty (ignoring .zfs ?) -> `/` is not allowed
  by default
- unless a flag is set -> in case we forget to handle something, we need
  an escape hatch
- if the flag is set, check whether .chunks already exists, and if it
  does, do not recreate the chunk store

that way, we could also solve the "re-add datastore after re-install"
issue users are frequently facing..

obviously, even with that we can explicitly always forbid '/' (before or
after implementing such a mechanism), since that one is always wrong.

> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>  src/api2/config/datastore.rs | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/src/api2/config/datastore.rs b/src/api2/config/datastore.rs
> index 6b742acb..671f07e9 100644
> --- a/src/api2/config/datastore.rs
> +++ b/src/api2/config/datastore.rs
> @@ -1,7 +1,7 @@
>  use std::path::PathBuf;
>  
>  use ::serde::{Deserialize, Serialize};
> -use anyhow::Error;
> +use anyhow::{bail, Error};
>  use hex::FromHex;
>  use serde_json::Value;
>  
> @@ -74,6 +74,10 @@ pub(crate) fn do_create_datastore(
>  ) -> Result<(), Error> {
>      let path: PathBuf = datastore.path.clone().into();
>  
> +    if path.parent().is_none() {
> +        bail!("cannot create datastore in root path");
> +    }
> +
>      let tuning: DatastoreTuning = serde_json::from_value(
>          DatastoreTuning::API_SCHEMA
>              .parse_property_string(datastore.tuning.as_deref().unwrap_or(""))?,
> -- 
> 2.43.0
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel