From: Dietmar Maurer <dietmar@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] applied: [PATCH proxmox-backup] api2/config/tape_backup_job: fix duplicate id parameter
Date: Wed, 24 Feb 2021 10:47:46 +0100 (CET) [thread overview]
Message-ID: <1710140015.34.1614160067335@webmail.proxmox.com> (raw)
In-Reply-To: <469741124.32.1614157327650@webmail.proxmox.com>
> > Cant we simple omit fixed properties from the Updater?
>
> I could try. I'd have to split out the Builder functionality of the Updatable
> trait, which is currently what allows `Option<T: Updatable>` to be generically
> implemented without specialization, but I could in theory generate implementations
> for Option types on the fly as well...
> (Currently there's a generic `impl Updatable for Option<T>` going like this:
> if the option is Some() already, then update_from(), otherwise try_build_from().)
I simply do not know how the current Updater is supposed to be used. Please can you provide
and example?
The current code in src/api2/config/tape_backup_job.rs looks clumsy, and I am
unsure if it works at all with multiple 'fixed' properties.
next prev parent reply other threads:[~2021-02-24 9:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 14:54 [pbs-devel] " Dominik Csapak
2021-02-23 16:26 ` [pbs-devel] applied: " Dietmar Maurer
2021-02-23 17:00 ` Thomas Lamprecht
2021-02-23 19:27 ` Dietmar Maurer
2021-02-24 6:13 ` Dietmar Maurer
2021-02-24 7:28 ` Dietmar Maurer
2021-02-24 8:35 ` Wolfgang Bumiller
2021-02-24 8:42 ` Dietmar Maurer
2021-02-24 9:02 ` Wolfgang Bumiller
2021-02-24 9:47 ` Dietmar Maurer [this message]
2021-02-25 8:53 ` Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1710140015.34.1614160067335@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.