all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Erik Fastermann <e.fastermann@proxmox.com>
To: pbs-devel@lists.proxmox.com, pdm-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox{,-backup,-datacenter-manager} 0/3] factor system report into shared crate
Date: Tue, 14 Jul 2026 11:05:00 +0200	[thread overview]
Message-ID: <170a29a4-291b-41ee-a045-9dbb0cc132ec@proxmox.com> (raw)
In-Reply-To: <20260714083156.99794-1-e.fastermann@proxmox.com>

Just noticed that this relies on unapplied patches for PBS [0] and PDM 
[1]: fix #7187: report: add ethtool output for physical interfaces

[0] 
https://lore.proxmox.com/pbs-devel/20260515083918.10590-1-e.fastermann@proxmox.com/
[1] 
https://lore.proxmox.com/pdm-devel/20260515084116.8028-1-e.fastermann@proxmox.com/

On 7/14/26 10:32 AM, Erik Fastermann wrote:
> This series moves the system report logic that was duplicated in
> PBS and PDM into a new shared proxmox-system-report crate.
> 
> proxmox:
>    Adds the proxmox-system-report crate holding the common file,
>    command and function collection, the unified section order
>    (FILES, COMMANDS, FUNCTIONS) and the merged set of general commands
>    run on every product.
> 
> proxmox-backup, proxmox-datacenter-manager:
>    Drop the duplicated logic and generate the report through the shared
>    crate, passing only their product specific files, commands and
>    functions.
> 
> The report content stays the same apart from two intentional effects
> of sharing one implementation: the top-level section order is now the
> same for both products, and the general command set is the union of
> what each ran before. PDM additionally emits FILES first now instead
> of last. Product specific entries are untouched.
> 
> 
> proxmox:
> 
> Erik Fastermann (1):
>    system-report: add crate for shared report generation
> 
>   Cargo.toml                                 |   2 +
>   proxmox-system-report/Cargo.toml           |  16 ++
>   proxmox-system-report/debian/copyright     |  18 ++
>   proxmox-system-report/debian/debcargo.toml |   7 +
>   proxmox-system-report/src/lib.rs           | 235 +++++++++++++++++++++
>   5 files changed, 278 insertions(+)
>   create mode 100644 proxmox-system-report/Cargo.toml
>   create mode 100644 proxmox-system-report/debian/copyright
>   create mode 100644 proxmox-system-report/debian/debcargo.toml
>   create mode 100644 proxmox-system-report/src/lib.rs
> 
> 
> proxmox-backup:
> 
> Erik Fastermann (1):
>    report: use shared proxmox-system-report crate
> 
>   Cargo.toml           |   2 +
>   src/server/report.rs | 213 +++----------------------------------------
>   2 files changed, 15 insertions(+), 200 deletions(-)
> 
> 
> proxmox-datacenter-manager:
> 
> Erik Fastermann (1):
>    report: use shared proxmox-system-report crate
> 
>   Cargo.toml           |   1 +
>   server/Cargo.toml    |   1 +
>   server/src/report.rs | 198 +------------------------------------------
>   3 files changed, 6 insertions(+), 194 deletions(-)
> 
> 
> Summary over all repositories:
>    10 files changed, 299 insertions(+), 394 deletions(-)
> 





      parent reply	other threads:[~2026-07-14  9:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14  8:31 [PATCH proxmox{,-backup,-datacenter-manager} 0/3] factor system report into shared crate Erik Fastermann
2026-07-14  8:31 ` [PATCH proxmox 1/3] system-report: add crate for shared report generation Erik Fastermann
2026-07-14  8:31   ` Erik Fastermann
2026-07-14  8:31 ` [PATCH proxmox-backup 2/3] report: use shared proxmox-system-report crate Erik Fastermann
2026-07-14  8:31   ` Erik Fastermann
2026-07-14  8:31 ` [PATCH proxmox-datacenter-manager 3/3] " Erik Fastermann
2026-07-14  8:31   ` Erik Fastermann
2026-07-14  9:05 ` Erik Fastermann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170a29a4-291b-41ee-a045-9dbb0cc132ec@proxmox.com \
    --to=e.fastermann@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal