From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 0DAC81FF0E4 for ; Tue, 14 Jul 2026 11:05:36 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D1413213D3; Tue, 14 Jul 2026 11:05:35 +0200 (CEST) Message-ID: <170a29a4-291b-41ee-a045-9dbb0cc132ec@proxmox.com> Date: Tue, 14 Jul 2026 11:05:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH proxmox{,-backup,-datacenter-manager} 0/3] factor system report into shared crate To: pbs-devel@lists.proxmox.com, pdm-devel@lists.proxmox.com References: <20260714083156.99794-1-e.fastermann@proxmox.com> Content-Language: en-US From: Erik Fastermann In-Reply-To: <20260714083156.99794-1-e.fastermann@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784019884523 X-SPAM-LEVEL: Spam detection results: 1 AWL 1.168 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_ASCII_DIVIDERS 0.8 Email that uses ascii formatting dividers and possible spam tricks KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: N7KO2FBYJ2WUXCDAHIQ3QISWNRVBRBET X-Message-ID-Hash: N7KO2FBYJ2WUXCDAHIQ3QISWNRVBRBET X-MailFrom: e.fastermann@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Just noticed that this relies on unapplied patches for PBS [0] and PDM [1]: fix #7187: report: add ethtool output for physical interfaces [0] https://lore.proxmox.com/pbs-devel/20260515083918.10590-1-e.fastermann@proxmox.com/ [1] https://lore.proxmox.com/pdm-devel/20260515084116.8028-1-e.fastermann@proxmox.com/ On 7/14/26 10:32 AM, Erik Fastermann wrote: > This series moves the system report logic that was duplicated in > PBS and PDM into a new shared proxmox-system-report crate. > > proxmox: > Adds the proxmox-system-report crate holding the common file, > command and function collection, the unified section order > (FILES, COMMANDS, FUNCTIONS) and the merged set of general commands > run on every product. > > proxmox-backup, proxmox-datacenter-manager: > Drop the duplicated logic and generate the report through the shared > crate, passing only their product specific files, commands and > functions. > > The report content stays the same apart from two intentional effects > of sharing one implementation: the top-level section order is now the > same for both products, and the general command set is the union of > what each ran before. PDM additionally emits FILES first now instead > of last. Product specific entries are untouched. > > > proxmox: > > Erik Fastermann (1): > system-report: add crate for shared report generation > > Cargo.toml | 2 + > proxmox-system-report/Cargo.toml | 16 ++ > proxmox-system-report/debian/copyright | 18 ++ > proxmox-system-report/debian/debcargo.toml | 7 + > proxmox-system-report/src/lib.rs | 235 +++++++++++++++++++++ > 5 files changed, 278 insertions(+) > create mode 100644 proxmox-system-report/Cargo.toml > create mode 100644 proxmox-system-report/debian/copyright > create mode 100644 proxmox-system-report/debian/debcargo.toml > create mode 100644 proxmox-system-report/src/lib.rs > > > proxmox-backup: > > Erik Fastermann (1): > report: use shared proxmox-system-report crate > > Cargo.toml | 2 + > src/server/report.rs | 213 +++---------------------------------------- > 2 files changed, 15 insertions(+), 200 deletions(-) > > > proxmox-datacenter-manager: > > Erik Fastermann (1): > report: use shared proxmox-system-report crate > > Cargo.toml | 1 + > server/Cargo.toml | 1 + > server/src/report.rs | 198 +------------------------------------------ > 3 files changed, 6 insertions(+), 194 deletions(-) > > > Summary over all repositories: > 10 files changed, 299 insertions(+), 394 deletions(-) >