all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: [pbs-devel] partially-applied: [PATCH backup 1/4] disks: remove useless conversion to the same type
Date: Tue, 13 Feb 2024 11:30:48 +0100	[thread overview]
Message-ID: <1707820232.u0iuqkntmn.astroid@yuna.none> (raw)
In-Reply-To: <20240213095320.186188-1-m.sandoval@proxmox.com>

applied 1 and 3, comments for 2 and 4 sent as well..

On February 13, 2024 10:53 am, Maximiliano Sandoval wrote:
> Fixes the clippy lint:
> 
> ```
> warning: useless conversion to the same type: `std::ffi::OsString`
>     --> src/tools/disks/mod.rs:1161:9
>      |
> 1161 |         count_str.into(),
>      |         ^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `count_str`
>      |
>      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
> ```
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> This patch series contains the missing patches from my "last" clippy patch series.
> 
>  src/tools/disks/mod.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/tools/disks/mod.rs b/src/tools/disks/mod.rs
> index 78360b66..94f89e0a 100644
> --- a/src/tools/disks/mod.rs
> +++ b/src/tools/disks/mod.rs
> @@ -1158,7 +1158,7 @@ pub fn wipe_blockdev(disk: &Disk, worker: Arc<WorkerTask>) -> Result<(), Error>
>          of_path,
>          "bs=1M".into(),
>          "conv=fdatasync".into(),
> -        count_str.into(),
> +        count_str,
>      ];
>      dd_command.args(args);
>  
> -- 
> 2.39.2
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 




      parent reply	other threads:[~2024-02-13 10:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-13  9:53 [pbs-devel] " Maximiliano Sandoval
2024-02-13  9:53 ` [pbs-devel] [PATCH backup 2/4] backup-proxy: avoid block in if condition Maximiliano Sandoval
2024-02-13 10:29   ` Fabian Grünbichler
2024-02-13  9:53 ` [pbs-devel] [PATCH backup 3/4] report: inline errors in writeln! Maximiliano Sandoval
2024-02-13  9:53 ` [pbs-devel] [PATCH backup 4/4] api: use if-let pattern for error-only handling Maximiliano Sandoval
2024-02-13 10:26   ` Fabian Grünbichler
2024-02-13 10:30 ` Fabian Grünbichler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1707820232.u0iuqkntmn.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal