all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup] client: add "delete-groups" param to delete namespace
Date: Tue, 13 Feb 2024 10:48:22 +0100	[thread overview]
Message-ID: <1707817590.05fjp52dyc.astroid@yuna.none> (raw)
In-Reply-To: <20240212104342.73779-1-g.goller@proxmox.com>

but with a follow-up renaming 'dg' to 'value'..

On February 12, 2024 11:43 am, Gabriel Goller wrote:
> The api parameter "delete-groups" was missing on the
> proxmox-backup-client command. This allows the client to remove
> non-empty namespaces.
> 
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>  proxmox-backup-client/src/namespace.rs | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/proxmox-backup-client/src/namespace.rs b/proxmox-backup-client/src/namespace.rs
> index ce3f113b..abf31ef4 100644
> --- a/proxmox-backup-client/src/namespace.rs
> +++ b/proxmox-backup-client/src/namespace.rs
> @@ -132,11 +132,15 @@ async fn create_namespace(param: Value) -> Result<(), Error> {
>                  type: BackupNamespace,
>                  optional: true,
>              },
> +            "delete-groups": {
> +                description: "Destroys all groups in the hierarchy.",
> +                optional: true,
> +            },
>          }
>      },
>  )]
>  /// Delete an existing namespace.
> -async fn delete_namespace(param: Value) -> Result<(), Error> {
> +async fn delete_namespace(param: Value, delete_groups: Option<bool>) -> Result<(), Error> {
>      let repo = extract_repository_from_value(&param)?;
>      let backup_ns = optional_ns_param(&param)?;
>  
> @@ -145,7 +149,11 @@ async fn delete_namespace(param: Value) -> Result<(), Error> {
>      }
>  
>      let path = format!("api2/json/admin/datastore/{}/namespace", repo.store());
> -    let param = json!({ "ns": backup_ns });
> +    let mut param = json!({ "ns": backup_ns });
> +
> +    if let Some(dg) = delete_groups {
> +        param["delete-groups"] = serde_json::to_value(dg)?;
> +    }
>  
>      let client = connect(&repo)?;
>  
> -- 
> 2.43.0
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
> 




      reply	other threads:[~2024-02-13  9:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-12 10:43 [pbs-devel] " Gabriel Goller
2024-02-13  9:48 ` Fabian Grünbichler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1707817590.05fjp52dyc.astroid@yuna.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal