From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH ceph 1/2] patch: debian/rules: fix build type
Date: Wed, 10 Jan 2024 10:18:57 +0100 [thread overview]
Message-ID: <1704878272.void1gps3c.astroid@yuna.none> (raw)
In-Reply-To: <20240109145030.1647121-2-aderumier@odiso.com>
On January 9, 2024 3:50 pm, Alexandre Derumier wrote:
> source: https://github.com/ceph/ceph/pull/54891
this was not merged upstream, and I don't think it's needed as per the
discussions in both PRs if the other patch is pulled in.
> build packages with 'RelWithDebInfo' to avoid to build rocksdb in debug
>
> This is already the default in ubuntu packages
> https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1894453
> ---
> patches/0021-debian-rules-fix-buildtype.patch | 22 +++++++++++++++++++
> patches/series | 1 +
> 2 files changed, 23 insertions(+)
> create mode 100644 patches/0021-debian-rules-fix-buildtype.patch
>
> diff --git a/patches/0021-debian-rules-fix-buildtype.patch b/patches/0021-debian-rules-fix-buildtype.patch
> new file mode 100644
> index 000000000..8b6ef6b56
> --- /dev/null
> +++ b/patches/0021-debian-rules-fix-buildtype.patch
> @@ -0,0 +1,22 @@
> +From 1f4b106d49fc916994d97e273599f75caa904c3b Mon Sep 17 00:00:00 2001
> +From: Mark Nelson <mark.nelson@clyso.com>
> +Date: Thu, 14 Dec 2023 05:19:46 +0000
> +Subject: [PATCH] debian/rules: Fix build_type for massive performance gain
> +
> +Signed-off-by: Mark Nelson <mark.nelson@clyso.com>
> +---
> + debian/rules | 1 +
> + 1 file changed, 1 insertion(+)
> +
> +diff --git a/debian/rules b/debian/rules
> +index ed7f4a255ed4b..b28abb7d62788 100755
> +--- a/debian/rules
> ++++ b/debian/rules
> +@@ -29,6 +29,7 @@ extraopts += -DWITH_PYTHON3=3
> + extraopts += -DWITH_CEPHFS_JAVA=ON
> + extraopts += -DWITH_CEPHFS_SHELL=ON
> + extraopts += -DWITH_SYSTEMD=ON -DCEPH_SYSTEMD_ENV_DIR=/etc/default
> ++extraopts += -DCMAKE_BUILD_TYPE=RelWithDebInfo
> + extraopts += -DWITH_GRAFANA=ON
> + ifeq ($(DEB_HOST_ARCH), amd64)
> + extraopts += -DWITH_RBD_RWL=ON
> diff --git a/patches/series b/patches/series
> index 67a52ae7c..d9a3ff8f4 100644
> --- a/patches/series
> +++ b/patches/series
> @@ -13,3 +13,4 @@
> 0016-d-rules-fix-no-restart-on-upgrade.patch
> 0017-python3.10-pep-620.patch
> 0020-fix-4759-run-ceph-crash-daemon-with-www-data-group-f.patch
> +0021-debian-rules-fix-buildtype.patch
> \ No newline at end of file
> --
> 2.39.2
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
next prev parent reply other threads:[~2024-01-10 9:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 14:50 [pve-devel] [PATCH ceph 0/2] Build rocksdb in non-debug mode Alexandre Derumier
2024-01-09 14:50 ` [pve-devel] [PATCH ceph 1/2] patch: debian/rules: fix build type Alexandre Derumier
2024-01-10 9:18 ` Fabian Grünbichler [this message]
2024-01-09 14:50 ` [pve-devel] [PATCH ceph 2/2] patch: add 0022-rocksb-inherit-parent-cmake-cxx-flags.patch Alexandre Derumier
2024-01-09 15:39 ` [pve-devel] [PATCH ceph 0/2] Build rocksdb in non-debug mode Thomas Lamprecht
2024-01-09 15:46 ` DERUMIER, Alexandre
2024-01-09 16:12 ` Thomas Lamprecht
2024-01-09 16:16 ` DERUMIER, Alexandre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1704878272.void1gps3c.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.