From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: [pbs-devel] applied: [PATH proxmox-backup] gc: ignore if `lost+find` can't be accessed
Date: Tue, 12 Sep 2023 11:30:58 +0200 [thread overview]
Message-ID: <1694511035.4glea18oca.astroid@yuna.none> (raw)
In-Reply-To: <20230912091849.905183-1-h.laimer@proxmox.com>
with Fixes: and a follow-up improving the confusing comment there ;)
On September 12, 2023 11:18 am, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> pbs-datastore/src/datastore.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs
> index 3c68b919..0cb8f4c2 100644
> --- a/pbs-datastore/src/datastore.rs
> +++ b/pbs-datastore/src/datastore.rs
> @@ -892,7 +892,7 @@ impl DataStore {
> (Some(inner), None) => bail!("unexpected error on datastore traversal: {inner}"),
> };
> if inner.kind() == io::ErrorKind::PermissionDenied {
> - if err.depth() == 0 && path.ends_with("lost+found") {
> + if err.depth() <= 1 && path.ends_with("lost+found") {
> // allow skipping ext4 fsck-directory on EPERM only, otherwise we might prune
> // too many chunks. E.g., if users messed up with owner/perms on a rsync
> return Ok(());
> --
> 2.39.2
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
prev parent reply other threads:[~2023-09-12 9:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 9:18 [pbs-devel] " Hannes Laimer
2023-09-12 9:30 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1694511035.4glea18oca.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.