From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: [pve-devel] applied-series: [PATCH pve-network 0/2] add warning if sdn config in not include in /etc/network/interfaces
Date: Wed, 19 Jul 2023 11:52:49 +0200 [thread overview]
Message-ID: <1689760305.7dghxjr68w.astroid@yuna.none> (raw)
In-Reply-To: <20230623124941.895654-1-aderumier@odiso.com>
with first patch correctly attributed to me, since I wrote the change ;)
and fixed up the first warn to also be a log_warn.
also added two followups, one for the error message, the other for style
of the second patch - please shout if you notice something off with
either of those!
On June 23, 2023 2:49 pm, Alexandre Derumier wrote:
> - add a check at config generation
> - display specific message on status if vnet is not generated
>
>
> Alexandre Derumier (2):
> sdn: config generation : check if interfaces.d/sdn is sourced
> zones: status: display specific message if vnet is not generated.
>
> src/PVE/Network/SDN.pm | 11 ++++++++++-
> src/PVE/Network/SDN/Zones/Plugin.pm | 18 +++++++++++++-----
> src/PVE/Network/SDN/Zones/QinQPlugin.pm | 8 +-------
> src/PVE/Network/SDN/Zones/SimplePlugin.pm | 17 -----------------
> src/PVE/Network/SDN/Zones/VlanPlugin.pm | 8 +-------
> 5 files changed, 25 insertions(+), 37 deletions(-)
>
> --
> 2.39.2
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
prev parent reply other threads:[~2023-07-19 9:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 12:49 [pve-devel] " Alexandre Derumier
2023-06-23 12:49 ` [pve-devel] [PATCH pve-network 1/2] sdn: config generation : check if interfaces.d/sdn is sourced Alexandre Derumier
2023-06-23 12:49 ` [pve-devel] [PATCH pve-network 2/2] zones: status: display specific message if vnet is not generated Alexandre Derumier
2023-07-19 9:52 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1689760305.7dghxjr68w.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.