From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH pbs 1/2] pbs-client: backup-writer: use log::warn instead of eprintln!
Date: Wed, 19 Jul 2023 11:08:31 +0200 [thread overview]
Message-ID: <1689757640.77r04d4crm.astroid@yuna.none> (raw)
In-Reply-To: <20230607140701.125092-1-m.sandoval@proxmox.com>
with the bug number fixed-up, and the (new) info message improved as
follow-up.
On June 7, 2023 4:07 pm, Maximiliano Sandoval wrote:
> The errors are not fatal so we only throw a warning.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> pbs-client/src/backup_writer.rs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/pbs-client/src/backup_writer.rs b/pbs-client/src/backup_writer.rs
> index be6da2a6..2e18a060 100644
> --- a/pbs-client/src/backup_writer.rs
> +++ b/pbs-client/src/backup_writer.rs
> @@ -293,7 +293,7 @@ impl BackupWriter {
> )
> .await
> {
> - eprintln!("Error downloading .fidx from previous manifest: {}", err);
> + log::warn!("Error downloading .fidx from previous manifest: {}", err);
> }
> }
> Ok(ArchiveType::DynamicIndex) => {
> @@ -305,7 +305,7 @@ impl BackupWriter {
> )
> .await
> {
> - eprintln!("Error downloading .didx from previous manifest: {}", err);
> + log::warn!("Error downloading .didx from previous manifest: {}", err);
> }
> }
> _ => { /* do nothing */ }
> --
> 2.39.2
>
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
>
>
>
prev parent reply other threads:[~2023-07-19 9:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 14:07 [pbs-devel] " Maximiliano Sandoval
2023-06-07 14:07 ` [pbs-devel] [PATCH pbs 2/2] fix #4761: pbs-client: backup_writer: improve error reporting Maximiliano Sandoval
2023-06-07 14:11 ` Maximiliano Sandoval
2023-07-19 9:08 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1689757640.77r04d4crm.astroid@yuna.none \
--to=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.