From: Dietmar Maurer <dietmar@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [RFC PATCH] fix #3106: correctly queue incoming connections
Date: Tue, 3 Nov 2020 16:54:50 +0100 (CET) [thread overview]
Message-ID: <1681771660.719.1604418891134@webmail.proxmox.com> (raw)
In-Reply-To: <20201103141556.ezlgmu36xlyfhvxy@wobu-vie.proxmox.com>
> On Tue, Nov 03, 2020 at 02:25:21PM +0100, Dietmar Maurer wrote:
> > > > - let connections = proxmox_backup::tools::async_io::HyperAccept(connections);
> > > > + let connections = accept_connections(listener, acceptor);
> > > > + let connections = hyper::server::accept::from_stream(connections);
> > >
> > > If we move the `from_stream` into the function below...
> >
> > I have tried to do that for 2 hours, then gave up....
> > So please tell m e how to make that work!
>
> nvm, the required feature is still unstable, we'd need to
>
> -> impl Accept<Conn: AsyncRead, Error: std::error::Error>
>
> but trait bounds on associated types in impl returns is unstable...
> Link: https://github.com/rust-lang/rust/issues/52662
>
> :(
Well, I call this a serious compiler bug ...
Anyways, my workaround is a single line of code.
next prev parent reply other threads:[~2020-11-03 15:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 12:26 Dietmar Maurer
2020-11-03 12:51 ` Dominik Csapak
2020-11-03 13:05 ` Wolfgang Bumiller
2020-11-03 13:25 ` Dietmar Maurer
2020-11-03 14:15 ` Wolfgang Bumiller
2020-11-03 15:54 ` Dietmar Maurer [this message]
2020-11-03 17:45 ` Dietmar Maurer
2020-11-04 5:37 ` Dietmar Maurer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1681771660.719.1604418891134@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.