all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>, pmg-devel@lists.proxmox.com
Subject: [pmg-devel] applied: [PATCH pmg-api] RuleDB/Notify: properly en-/decode the mail subject
Date: Wed, 5 Oct 2022 18:36:38 +0200	[thread overview]
Message-ID: <166734bc-c85d-227c-72a1-c314c7af011c@proxmox.com> (raw)
In-Reply-To: <20221005074941.903941-1-d.csapak@proxmox.com>

Am 05/10/2022 um 09:49 schrieb Dominik Csapak:
> we need to mime decode the subject after reading it, so that we get
> the 'real' subject instead of the (possibly) mime encoded one (which
> might be base64 or quoted-printable encoded). To get a proper subject in
> the notification mail again, we have to encode it again before passing
> it MIME::Entity->build
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  src/PMG/RuleDB/Notify.pm | 3 ++-
>  src/bin/pmg-smtp-filter  | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
>

applied, with Stoiko's T-b & R-b tags, thanks!

(I didn't bother for the placement of the "No Subject" nit too much, albeit,
fwiw, it got my attetion to initially -  @Stoiko just fix it up if you directly
if you like it better the other way)




      parent reply	other threads:[~2022-10-05 16:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-05  7:49 [pmg-devel] " Dominik Csapak
2022-10-05 16:27 ` Stoiko Ivanov
2022-10-05 16:36 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166734bc-c85d-227c-72a1-c314c7af011c@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pmg-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal