From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] ui: qemu wizard: use better boot order for second cd drive
Date: Tue, 21 Nov 2023 14:37:54 +0100 [thread overview]
Message-ID: <1666e769-ad71-4f6e-80f5-4df4f7e0996f@proxmox.com> (raw)
In-Reply-To: <20231121083551.1016184-1-d.csapak@proxmox.com>
Am 21/11/2023 um 09:35 schrieb Dominik Csapak:
> in the case we add a second cd drive (for windows), we don't want the
> backend logic to only include the first one, since we cannot know
> which is bootable and which is (probably) the virtio iso.
>
> so instead, emulate the backend logic for the wizard but include both cd
> drives in that case, otherwise let the backend decide like before
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> this is a follow up to "ui: vm wizard: allow second iso for windows vms":
> https://lists.proxmox.com/pipermail/pve-devel/2023-November/060546.html
>
> www/manager6/qemu/CreateWizard.js | 49 ++++++++++++++++++++++++++++++-
> 1 file changed, 48 insertions(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-11-21 13:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 8:35 [pve-devel] " Dominik Csapak
2023-11-21 13:37 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1666e769-ad71-4f6e-80f5-4df4f7e0996f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal