From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: [pve-devel] applied-series: [PATCH-SERIES v4 container/qemu-server] fix #3424: wait for active replication when deleting a snapshot
Date: Tue, 15 Mar 2022 13:34:45 +0100 [thread overview]
Message-ID: <1647347554.hjp2gv24x9.astroid@nora.none> (raw)
In-Reply-To: <20220223120359.45928-1-f.ebner@proxmox.com>
with some small follow-ups as discussed off-list:
- improve error messages in case of failure to acquire lock
- downgrade die to warn in pve-container vzdump patch, since it's not
fatal
On February 23, 2022 1:03 pm, Fabian Ebner wrote:
> Avoid that an attempt to remove a snapshot that's actively used by
> replication leads to a partially (or not) removed snapshot and locked
> guest.
>
> I decided to make the checks at the call sides, because passing the
> log function and timeout to snapshot_delete felt awkward as they
> would only be used for obtaining the lock.
>
> Changes from v3:
> * Unconditionally take the lock, to not race with replication job
> creation and future-proofing.
> * Only log in the case with the long timeout if we can't obtain
> the lock quickly.
> * Make message more general, because it might be another snapshot
> removal operation holding the lock.
>
>
> container:
>
> Fabian Ebner (2):
> partially fix #3424: vzdump: cleanup: wait for active replication
> fix #3424: api: snapshot delete: wait for active replication
>
> src/PVE/API2/LXC/Snapshot.pm | 11 ++++++++++-
> src/PVE/VZDump/LXC.pm | 20 ++++++++++++++++++--
> 2 files changed, 28 insertions(+), 3 deletions(-)
>
>
> qemu-server:
>
> Fabian Ebner (1):
> fix #3424: api: snapshot delete: wait for active replication
>
> PVE/API2/Qemu.pm | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> --
> 2.30.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
>
prev parent reply other threads:[~2022-03-15 12:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 12:03 [pve-devel] " Fabian Ebner
2022-02-23 12:03 ` [pve-devel] [PATCH v4 container 1/2] partially fix #3424: vzdump: cleanup: wait for active replication Fabian Ebner
2022-02-23 12:03 ` [pve-devel] [PATCH v4 container 2/2] fix #3424: api: snapshot delete: " Fabian Ebner
2022-02-23 12:03 ` [pve-devel] [PATCH v4 qemu-server 1/1] " Fabian Ebner
2022-03-15 12:34 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1647347554.hjp2gv24x9.astroid@nora.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.