all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: [pve-devel] applied: [PATCH firewall] fix #2721: remove reject tcp 43 from default drop and reject actions
Date: Fri, 06 Aug 2021 14:06:37 +0200	[thread overview]
Message-ID: <1628251520.kcdfunhkdm.astroid@nora.none> (raw)
In-Reply-To: <20210805105903.765052-1-l.stechauner@proxmox.com>

thanks!

On August 5, 2021 12:59 pm, Lorenz Stechauner wrote:
> first, '43' is a typo, it should say '113' (if it really is like
> legacy shorewall [0]). this tcp port corresponds to the ident or
> authentication service protocol.
> 
> second, nowdays this reject is not included in shorewall anymore.
> furthermore it would make no sense to reject specifically this
> one port.
> 
> [0] https://gitlab.com/shorewall/code/-/blob/4.6.13/Shorewall/action.Drop#L66
>     https://gitlab.com/shorewall/code/-/blob/4.6.13/Shorewall/Macros/macro.Auth
> 
> Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
> ---
>  src/PVE/Firewall.pm | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/PVE/Firewall.pm b/src/PVE/Firewall.pm
> index fc5c077..edc5336 100644
> --- a/src/PVE/Firewall.pm
> +++ b/src/PVE/Firewall.pm
> @@ -592,7 +592,6 @@ $pve_std_chains_conf->{4} = {
>  	# same as shorewall 'Drop', which is equal to DROP,
>  	# but REJECT/DROP some packages to reduce logging,
>  	# and ACCEPT critical ICMP types
> -	{ action => 'PVEFW-reject',  proto => 'tcp', dport => '43' }, # REJECT 'auth'
>  	# we are not interested in BROADCAST/MULTICAST/ANYCAST
>  	{ action => 'PVEFW-DropBroadcast' },
>  	# ACCEPT critical ICMP types
> @@ -615,7 +614,6 @@ $pve_std_chains_conf->{4} = {
>  	# same as shorewall 'Reject', which is equal to Reject,
>  	# but REJECT/DROP some packages to reduce logging,
>  	# and ACCEPT critical ICMP types
> -	{ action => 'PVEFW-reject',  proto => 'tcp', dport => '43' }, # REJECT 'auth'
>  	# we are not interested in BROADCAST/MULTICAST/ANYCAST
>  	{ action => 'PVEFW-DropBroadcast' },
>  	# ACCEPT critical ICMP types
> -- 
> 2.30.2
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 
> 




      reply	other threads:[~2021-08-06 12:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05 10:59 [pve-devel] " Lorenz Stechauner
2021-08-06 12:06 ` Fabian Grünbichler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1628251520.kcdfunhkdm.astroid@nora.none \
    --to=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal