Re: [pbs-devel] [PATCH 0/5] Add LVM (thin) support for single file restore

["Fabian Grünbichler" <f.gruenbichler@proxmox.com>]

Reviewed-By: Fabian Grünbichler <f.gruenbichler@proxmox.com>

requires a Breaks on the old restore image (else the restore daemon 
crashes because of missing lock/LVM support).

some potential for follow-ups/issues I encountered with a not-so-fast 
PBS instance and bigger VMs:
- increase VM start timeout (currently 12s?), as the initial scan of 
  disks seems to block responding to the startup status request, and 
  scanning all VGs/LVs can take quite a lot longer than that - 
  alternatively, fix this blockage and/or consider VM started sooner?
- filter out "known unreadable" LVs, like Ceph (bluestore) OSDs
- investigate '--sysinit' option for lvchange/vgchange (seems 
  appropriate for what we are doing inside the VM ;))
- investigate '-K' to allow looking at "non-auto-activatable" LVs

and as discussed off-list, I think we should switch to 
build-dependencies and copying binaries+needed libs in 
build-initramfs.sh instead of downloading .deb packages and extracting 
them only to remove part of their contents again - but that is firmly in 
"improve/cleanup build" territory, so lower priority than the above.

On June 30, 2021 5:57 pm, Stefan Reiter wrote:
> Uses LVM tools to support LVM(-thin) volumes in the single-file restore daemon.
> Tested with multi-disk LVs, thinpools and different filesystems on top of them.
> 
> Note for testing: The current proxmox-backup git master will not work for
> building the proxmox-restore-daemon binary, as the OpenID changes pull in some
> library dependencies not available in the restore VM.
> 
> 
> proxmox-backup-restore-image: Stefan Reiter (1):
>   add LVM (thin) tooling
> 
>  src/build_initramfs.sh | 6 ++++++
>  src/config-base        | 1 +
>  2 files changed, 7 insertions(+)
> 
> proxmox-backup: Stefan Reiter (4):
>   file-restore-daemon/disk: dedup BucketComponents and make size
>     optional
>   file-restore-daemon/disk: fix component path errors
>   file-restore-daemon/disk: ignore already-mounted error and prefix
>     zpool
>   file-restore-daemon/disk: add LVM (thin) support
> 
>  src/bin/proxmox_restore_daemon/api.rs  |   2 +-
>  src/bin/proxmox_restore_daemon/disk.rs | 222 +++++++++++++++++++++++--
>  2 files changed, 208 insertions(+), 16 deletions(-)
> 
> -- 
> 2.30.2
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
>