Re: [pve-devel] [PATCH storage 2/3] update reminder to remove maxfiles

From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH storage 2/3] update reminder to remove maxfiles
Date: Tue, 08 Jun 2021 15:04:00 +0200	[thread overview]
Message-ID: <1623157330.74f1vq87w2.astroid@nora.none> (raw)
In-Reply-To: <20210604134946.152720-9-f.ebner@proxmox.com>

On June 4, 2021 3:49 pm, Fabian Ebner wrote:
> Remove it later, once it's been deprecated for a while.

shouldn't we start warning that it is deprecated? or at least add a 
deprecation notice to the parameter description?

> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>  PVE/Storage.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/PVE/Storage.pm b/PVE/Storage.pm
> index aa36bad..0b3671a 100755
> --- a/PVE/Storage.pm
> +++ b/PVE/Storage.pm
> @@ -125,7 +125,7 @@ sub lock_storage_config {
>      }
>  }
>  
> -# FIXME remove maxfiles for PVE 7.0
> +# FIXME remove maxfiles for PVE 8.0 or PVE 9.0
>  my $convert_maxfiles_to_prune_backups = sub {
>      my ($scfg) = @_;
>  
> -- 
> 2.30.2
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 
> 