From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] Feature: OAuth / OpenID-connect implementation - II
Date: Tue, 15 Dec 2020 09:40:07 +0100 [thread overview]
Message-ID: <1608021512.lhqm96y4cq.astroid@nora.none> (raw)
In-Reply-To: <5FD7F8EA0200008800004149@mail.comsolve.nl>
On December 15, 2020 12:44 am, Michael Honkoop wrote:
> Hi all,
>
> In watching build-behaviour, i notice that when i build another git repo (pve-manager) it drops the directory 'dest' and then ( if one deletes the resulting *buildinfo, *.changes and *.deb) starts rebuilding.
>
> On the pve-access-control it does not remove the directory 'libpve-access-control-6.1' , so when one has this dir, ( and assuming same behaviour as seen on pve-manager repo) it will take all sources from this dir - regardless of changes.
>
> Is there a specific reason this differs from the pve-manager repo ? - as only after analysing why my added file was skipped over and over again ( in pve-access-control ) has lead me to a lot of questionmarks in my mind.
no, no specific reason except that Makefiles tend to grow over time, and
sometimes improvements/changes don't make it to all of them. feel free
to improve upon it if you want, for the smaller repos when in doubt just
add a 'make clean' before your build - the build should be rather fast
anyway even when starting from scratch ;)
prev parent reply other threads:[~2020-12-15 8:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-13 1:16 [pve-devel] Feature: OAuth / OpenID-connect implementation Michael Honkoop
2020-12-14 7:12 ` Fabian Grünbichler
2020-12-14 23:12 ` Michael Honkoop
2020-12-14 23:44 ` [pve-devel] Feature: OAuth / OpenID-connect implementation - II Michael Honkoop
2020-12-15 8:40 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1608021512.lhqm96y4cq.astroid@nora.none \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.