From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [RFC PATCH backup-restore-image] enable the codepage 437 for FAT filesystems
Date: Thu, 10 Apr 2025 13:24:47 +0200 (CEST) [thread overview]
Message-ID: <1589334087.2123.1744284288000@192.168.2.153> (raw)
In-Reply-To: <20250410105046.897410-1-d.csapak@proxmox.com>
https://lore.proxmox.com/all/20241126132602.576027-1-s.ivanov@proxmox.com/ ;)
also see some discussions on v1 there: https://lore.proxmox.com/all/20241126120357.389046-1-s.ivanov@proxmox.com/
> Dominik Csapak <d.csapak@proxmox.com> hat am 10.04.2025 12:50 CEST geschrieben:
>
>
> This enables mounting fat32 formatted volumes, since codepage 437 is the
> default when mounting such volumes. (E.g. this also allows mounting EFI
> partitions)
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> stumbled upon this while doing file restore tests
>
> Not sure if we just want to enable this one codepage or more. In our
> normal kernel build, this is enabled by default (and marked as such),
> and the others are built as modules.
>
> src/config-base | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/config-base b/src/config-base
> index 1581b09..edd95c1 100644
> --- a/src/config-base
> +++ b/src/config-base
> @@ -102,6 +102,7 @@ CONFIG_SYSFS=y
> CONFIG_NLS=y
> CONFIG_NLS_UTF8=y
> CONFIG_NLS_ISO8859_1=y
> +CONFIG_NLS_CODEPAGE_437=y
> CONFIG_MSDOS_PARTITION=y
> CONFIG_EFI_PARTITION=y
> CONFIG_FILE_LOCKING=y
> --
> 2.39.5
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-04-10 11:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 10:50 Dominik Csapak
2025-04-10 11:24 ` Fabian Grünbichler [this message]
2025-04-10 11:41 ` Dominik Csapak
2025-04-10 11:44 ` Fabian Grünbichler
2025-04-10 11:47 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1589334087.2123.1744284288000@192.168.2.153 \
--to=f.gruenbichler@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal