all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: [pve-devel] applied: [PATCH 1/3] Revert "dark-theme: let the background "shine through" mask more"
Date: Tue, 21 Mar 2023 14:05:00 +0100	[thread overview]
Message-ID: <1546649a-2aef-7262-d221-a374d670a11c@proxmox.com> (raw)
In-Reply-To: <20230321100425.85065-1-w.bumiller@proxmox.com>

Am 21/03/2023 um 11:04 schrieb Wolfgang Bumiller:
> This looks horrible.
> 
> A *much* *much* better way to improve readability is to
> simply set the opacity down to 0.5.
> 
> This reverts commit 2c837f5766b48629a835c62d4b7af6c3ae4dc1c0.
> ---
> I can't stand this.
> Seriously.
> 
>  src/proxmox-dark/scss/extjs/_presentation.scss | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
>

applied all three patches, they actually fulfil my request to be able to still
read the stuff in the bg even a bit better and look fine enough otherwise, thanks!

FWIW, just from a aesthetic POV the best way to make modal windows stand out would
be to blur the background, i.e.:

.x-mask {
    background-color: rgba(0,0,0,0.5);
    backdrop-filter: blur(2px);
}

(backdrop-filter + opacity doesn't work, so one needs to use rgba instead)

But I prefer usability/accessibility over aesthetics here.




  parent reply	other threads:[~2023-03-21 13:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-21 10:04 [pve-devel] " Wolfgang Bumiller
2023-03-21 10:04 ` [pve-devel] [PATCH 2/3] dark-mode: reduce background mask opacity to 0.5 Wolfgang Bumiller
2023-03-21 10:04 ` [pve-devel] [PATCH 3/3] dark-mode: make shadow black Wolfgang Bumiller
2023-03-21 13:05 ` Thomas Lamprecht [this message]
2023-03-21 14:04   ` [pve-devel] applied: [PATCH 1/3] Revert "dark-theme: let the background "shine through" mask more" Stefan Sterz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1546649a-2aef-7262-d221-a374d670a11c@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=w.bumiller@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal