From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>,
pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-api] api: make SHA-256 fingerprint regex match only hex characters
Date: Wed, 30 Oct 2024 12:30:30 +0100 (CET) [thread overview]
Message-ID: <1511397665.5078.1730287830954@webmail.proxmox.com> (raw)
In-Reply-To: <20241030111857.166676-1-m.sandoval@proxmox.com>
so this touches exactly the same code as the other patch you sent half an hour earlier, but no indication here. this should have been a v2 of that patch turning it into a series, but please see my comment there first ;)
> Maximiliano Sandoval <m.sandoval@proxmox.com> hat am 30.10.2024 12:18 CET geschrieben:
>
>
> The fingerprints are in hex, plus colons, and should only match A-F.
>
> Suggested-by: Shannon Sterz <s.sterz@proxmox.com>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> src/PMG/API2/Cluster.pm | 2 +-
> src/PMG/CLI/pmgcm.pm | 2 +-
> src/PMG/ClusterConfig.pm | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/PMG/API2/Cluster.pm b/src/PMG/API2/Cluster.pm
> index 84dafabb..cc54fb50 100644
> --- a/src/PMG/API2/Cluster.pm
> +++ b/src/PMG/API2/Cluster.pm
> @@ -411,7 +411,7 @@ __PACKAGE__->register_method({
> fingerprint => {
> description => "SSL certificate fingerprint.",
> type => 'string',
> - pattern => '^(:?[A-Z0-9][A-Z0-9]:){31}[A-Z0-9][A-Z0-9]$',
> + pattern => '^(:?[A-F0-9][A-F0-9]:){31}[A-F0-9][A-F0-9]$',
> },
> password => {
> description => "Superuser password.",
> diff --git a/src/PMG/CLI/pmgcm.pm b/src/PMG/CLI/pmgcm.pm
> index ecf9cc76..641b4be2 100644
> --- a/src/PMG/CLI/pmgcm.pm
> +++ b/src/PMG/CLI/pmgcm.pm
> @@ -169,7 +169,7 @@ __PACKAGE__->register_method({
> fingerprint => {
> description => "SSL certificate fingerprint.",
> type => 'string',
> - pattern => '^(:?[A-Z0-9][A-Z0-9]:){31}[A-Z0-9][A-Z0-9]$',
> + pattern => '^(:?[A-F0-9][A-F0-9]:){31}[A-F0-9][A-F0-9]$',
> optional => 1,
> },
> },
> diff --git a/src/PMG/ClusterConfig.pm b/src/PMG/ClusterConfig.pm
> index c52508dc..67b2a512 100644
> --- a/src/PMG/ClusterConfig.pm
> +++ b/src/PMG/ClusterConfig.pm
> @@ -75,7 +75,7 @@ sub properties {
> fingerprint => {
> description => "SSL certificate fingerprint.",
> type => 'string',
> - pattern => '^(:?[A-Z0-9][A-Z0-9]:){31}[A-Z0-9][A-Z0-9]$',
> + pattern => '^(:?[A-F0-9][A-F0-9]:){31}[A-F0-9][A-F0-9]$',
> },
> };
> }
> --
> 2.39.5
>
>
>
> _______________________________________________
> pmg-devel mailing list
> pmg-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
prev parent reply other threads:[~2024-10-30 11:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 11:18 Maximiliano Sandoval
2024-10-30 11:30 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511397665.5078.1730287830954@webmail.proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.