From: Christian Ebner <c.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 1/3] fix #5255: node: wol: add optional bind interface
Date: Fri, 22 Mar 2024 15:37:20 +0100 (CET) [thread overview]
Message-ID: <1497358452.782.1711118240501@webmail.proxmox.com> (raw)
In-Reply-To: <be55ec4c-c9de-491b-83a2-534b0827dad6@proxmox.com>
> On 21.03.2024 18:27 CET Thomas Lamprecht <t.lamprecht@proxmox.com> wrote:
>
>
> On 05/03/2024 13:54, Christian Ebner wrote:
> > + 'wakeonlan-bind-interface' => {
> > + type => 'string',
> > + description => 'Bind to this interface when sending wake on LAN packet',
> > + format => 'pve-iface',
> > + optional => 1,
> > + },
>
> we could transform the existing "wakeonlan" property into a format string,
> keep the new mac property as default_key there for backwards compat, kinda
> like "acme" is a format string in the same config.
>
> For such a config option that would be IMO fitting and avoid bloating the
> "top-level" format.
Agreed, will send a new version with the suggested changes to the format
string.
next prev parent reply other threads:[~2024-03-22 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-05 12:54 [pve-devel] [PATCH manager docs 0/3] add optional WoL config options Christian Ebner
2024-03-05 12:54 ` [pve-devel] [PATCH manager 1/3] fix #5255: node: wol: add optional bind interface Christian Ebner
2024-03-21 17:27 ` Thomas Lamprecht
2024-03-22 14:37 ` Christian Ebner [this message]
2024-03-26 9:21 ` Christian Ebner
2024-03-05 12:54 ` [pve-devel] [PATCH manager 2/3] fix #5255: node: wol: configurable broadcast address Christian Ebner
2024-03-05 12:54 ` [pve-devel] [PATCH docs 3/3] pvenode/wake-on-lan: mention optional config options Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497358452.782.1711118240501@webmail.proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.