From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Stefan Reiter <s.reiter@proxmox.com>
Subject: [pbs-devel] applied: [RFC 0/2] backup client: implement some HTTP timeouts
Date: Tue, 22 Dec 2020 13:32:42 +0100 (CET) [thread overview]
Message-ID: <144907618.2193.1608640363259@webmail.proxmox.com> (raw)
In-Reply-To: <20201221135611.14456-1-s.reiter@proxmox.com>
applied
> On 12/21/2020 2:56 PM Stefan Reiter <s.reiter@proxmox.com> wrote:
>
>
> Not a comprehensive overhaul, but should fix the most common hangs to at least
> finish *sometime*. Tested on an intentionally slow PBS with VM backups - QEMU
> still hangs, but resumes to work after 20 seconds as intended.
>
> 20 seconds was chosen by fair dice roll, seems to be a good limit for opening an
> HTTP connection (so not counting actual data transfer)?
>
> Disclaimer: The 'proxmox' patches were a *bit* over my head, so I hope the
> generics and stuff make sense, appreciate any feedback there - it's certainly
> interesting to play with higher-level Rust like this, would love to learn :)
>
>
> proxmox: Stefan Reiter (1):
> add tools::future with TimeoutFutureExt
>
> proxmox/src/tools/future.rs | 48 +++++++++++++++++++++++++++++++++++++
> proxmox/src/tools/mod.rs | 1 +
> 2 files changed, 49 insertions(+)
> create mode 100644 proxmox/src/tools/future.rs
>
> proxmox-backup: Stefan Reiter (1):
> http_client: add timeouts for critical connects
>
> src/client/http_client.rs | 17 ++++++++++++++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
>
> --
> 2.20.1
>
>
> _______________________________________________
> pbs-devel mailing list
> pbs-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2020-12-22 12:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 13:56 [pbs-devel] " Stefan Reiter
2020-12-21 13:56 ` [pbs-devel] [RFC proxmox 1/2] add tools::future with TimeoutFutureExt Stefan Reiter
2020-12-21 13:56 ` [pbs-devel] [RFC proxmox-backup 2/2] http_client: add timeouts for critical connects Stefan Reiter
2020-12-21 15:36 ` [pbs-devel] [RFC 0/2] backup client: implement some HTTP timeouts Dietmar Maurer
2020-12-21 15:45 ` Dietmar Maurer
2020-12-21 15:49 ` Stefan Reiter
2020-12-21 16:40 ` Dietmar Maurer
2020-12-22 8:47 ` Stefan Reiter
2020-12-22 10:40 ` Dietmar Maurer
2020-12-22 12:32 ` Dietmar Maurer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=144907618.2193.1608640363259@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=s.reiter@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal