From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>,
pmg-devel@lists.proxmox.com
Subject: Re: [pmg-devel] [PATCH pmg-api] api: document that SSL fingerprints are SHA-256
Date: Wed, 30 Oct 2024 12:28:22 +0100 (CET) [thread overview]
Message-ID: <1419348031.5069.1730287702708@webmail.proxmox.com> (raw)
In-Reply-To: <20241030104558.133410-1-m.sandoval@proxmox.com>
> Maximiliano Sandoval <m.sandoval@proxmox.com> hat am 30.10.2024 11:45 CET geschrieben:
>
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>
> The regex pattern bellow matches the lenght (64 characters plus colons) of a
> SHA-256 fingerprint.
and there is a standard option for it in PVE::JSONSchema that should be used instead ;)
it has one slight difference, but that can be accounted here easily if needed (it allows lower case hex characters as well as upper case).
>
> src/PMG/API2/Cluster.pm | 2 +-
> src/PMG/CLI/pmgcm.pm | 2 +-
> src/PMG/ClusterConfig.pm | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/src/PMG/API2/Cluster.pm b/src/PMG/API2/Cluster.pm
> index 84dafabb..df5df949 100644
> --- a/src/PMG/API2/Cluster.pm
> +++ b/src/PMG/API2/Cluster.pm
> @@ -409,7 +409,7 @@ __PACKAGE__->register_method({
> type => 'string', format => 'ip',
> },
> fingerprint => {
> - description => "SSL certificate fingerprint.",
> + description => "SSL certificate SHA-256 fingerprint.",
> type => 'string',
> pattern => '^(:?[A-Z0-9][A-Z0-9]:){31}[A-Z0-9][A-Z0-9]$',
> },
> diff --git a/src/PMG/CLI/pmgcm.pm b/src/PMG/CLI/pmgcm.pm
> index ecf9cc76..a2d46910 100644
> --- a/src/PMG/CLI/pmgcm.pm
> +++ b/src/PMG/CLI/pmgcm.pm
> @@ -167,7 +167,7 @@ __PACKAGE__->register_method({
> type => 'string', format => 'ip',
> },
> fingerprint => {
> - description => "SSL certificate fingerprint.",
> + description => "SSL certificate SHA-256 fingerprint.",
> type => 'string',
> pattern => '^(:?[A-Z0-9][A-Z0-9]:){31}[A-Z0-9][A-Z0-9]$',
> optional => 1,
> diff --git a/src/PMG/ClusterConfig.pm b/src/PMG/ClusterConfig.pm
> index c52508dc..2ca1b104 100644
> --- a/src/PMG/ClusterConfig.pm
> +++ b/src/PMG/ClusterConfig.pm
> @@ -73,7 +73,7 @@ sub properties {
> pattern => valid_ssh_pubkey_regex(),
> },
> fingerprint => {
> - description => "SSL certificate fingerprint.",
> + description => "SSL certificate SHA-256 fingerprint.",
> type => 'string',
> pattern => '^(:?[A-Z0-9][A-Z0-9]:){31}[A-Z0-9][A-Z0-9]$',
> },
> --
> 2.39.5
>
>
>
> _______________________________________________
> pmg-devel mailing list
> pmg-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel
prev parent reply other threads:[~2024-10-30 11:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 10:45 Maximiliano Sandoval
2024-10-30 11:28 ` Fabian Grünbichler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419348031.5069.1730287702708@webmail.proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.