[pve-devel] [PATCH installer] unconfigured.sh: drop networking stop upon reboot

[pve-devel] [PATCH installer] unconfigured.sh: drop networking stop upon reboot

[Stoiko Ivanov]

This is (afaics) a purely cosmetic change.

With PVE 7.0 the ISO does not ship ifupdown/ifupdown2 in the installer
environment anymore - ifup/ifdown are currently provided by busybox.

Since we stop all daemonized processes with killall5, this takes care
of the dhclient instances - so just drop the invocation of the non
existing script.

Noticed while checking out 2 improvments to the installer.

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
 unconfigured.sh | 2 --
 1 file changed, 2 deletions(-)

diff --git a/unconfigured.sh b/unconfigured.sh
index 98b8d9c..35ec0ee 100755
--- a/unconfigured.sh
+++ b/unconfigured.sh
@@ -47,8 +47,6 @@ eject_and_reboot() {
 real_reboot() {
     trap - ERR
 
-    /etc/init.d/networking stop
-
     # stop udev (release file handles)
     /etc/init.d/udev stop
 
-- 
2.30.2

Re: [pve-devel] [PATCH installer] unconfigured.sh: drop networking stop upon reboot

[Thomas Lamprecht]

On 12.07.21 10:32, Stoiko Ivanov wrote:
> This is (afaics) a purely cosmetic change.
> 
> With PVE 7.0 the ISO does not ship ifupdown/ifupdown2 in the installer
> environment anymore - ifup/ifdown are currently provided by busybox.
> 
> Since we stop all daemonized processes with killall5, this takes care
> of the dhclient instances - so just drop the invocation of the non
> existing script.
> 
> Noticed while checking out 2 improvments to the installer.
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
>  unconfigured.sh | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/unconfigured.sh b/unconfigured.sh
> index 98b8d9c..35ec0ee 100755
> --- a/unconfigured.sh
> +++ b/unconfigured.sh
> @@ -47,8 +47,6 @@ eject_and_reboot() {
>  real_reboot() {
>      trap - ERR
>  
> -    /etc/init.d/networking stop
> -
>      # stop udev (release file handles)
>      /etc/init.d/udev stop
>  
> 

funnily noticed that too and had a `if [[ -x /etc/init.d/networking ]]; ...` already committed
locally, I pushed that one out - may make sense to fully remove it in the future.