Re: [pbs-devel] [PATCH docs] move custom.css from 'docs/' to 'docs/_static/'

[Dylan Whyte <d.whyte@proxmox.com>]

Hi Thomas,

You are right, and I am very sorry to have wasted that time with a silly mistake.. Lesson learned
and I assure you it won't happen again!

Dylan

> On 14.09.2020 09:32 Thomas Lamprecht <t.lamprecht@proxmox.com> wrote:
> 
>  
> On 9/11/20 4:08 PM, Dylan Whyte wrote:
> > conf.py sets the variable html_static_path to a folder
> > named '_static'. This is where sphinx searches for custom
> > stylesheets, so before this change, custom.css had no effect.
> 
> I sure did have an effect, a `make install` or a `make proxmox-backup-docs`
> plus `dpkg -i ./*.deb` should show it also in your build setup, or?
> 
> Note, that sphinx outputs more than one render, e.g., latex, html (epub and
> some others would be a possibility too), so the `html_static_path` refers
> to the html output and I copy it there after the sphinx build of HTML is
> finished.
> 
> Note also that this patch breaks any build, as the makefile cannot do the copy
> any more, that would have been easily caught by testing a single build..
> So please, one thing I'd expect people to do before sending patches is at
> least a simple build test, a more functional test is naturally also expected
> but if it doesn't even build after ones patch is applied it feels like a waste
> of reviewers time, which is 100 times more scarce than developer time..
> 
> This should not sound to much like scolding, but please ingrain a final build
> and quick functional test step before you send any patch it in your workflow.
> 
> Thank you!