From: Dietmar Maurer <dietmar@proxmox.com>
To: "Proxmox Backup Server development discussion"
<pbs-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/6] src/server/worker_task.rs: Avoid using pbs-api-type::Authid
Date: Fri, 24 Sep 2021 11:03:34 +0200 (CEST) [thread overview]
Message-ID: <1359850202.598.1632474214118@webmail.proxmox.com> (raw)
> On 09/23/2021 3:20 PM Fabian Grünbichler <f.gruenbichler@proxmox.com> wrote:
>
>
> On September 23, 2021 12:13 pm, Dietmar Maurer wrote:
> > Because we want to move worker_task.rs into proxmox-rest-server crate.
>
> as discussed off-list, we could use a
>
> struct AuthidStr(String)
>
> or a trait defined in proxmox instead of a regular String, to avoid
> accidentally passing in other, non authid strings. all Authid
> implementations would then need to implement Into<AuthidStr> (/the
> trait), and the calls below to to_string() would become into() (remain
> as they were).
>
> can also be done as follow-up with a proxmox bump if we want to discuss
> it more in-depth but still go ahead with the split/move now.
I am still not sure whats the best way to implement this, so I committed
what we have so far...
next reply other threads:[~2021-09-24 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 9:03 Dietmar Maurer [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-09-23 10:13 Dietmar Maurer
2021-09-23 13:20 ` Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359850202.598.1632474214118@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.