From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Christian Ebner <c.ebner@proxmox.com>
Subject: Re: [pbs-devel] [RFC proxmox-backup] fix #5710: api: backup: stat known chunks during backup
Date: Wed, 18 Sep 2024 10:54:23 +0200 (CEST) [thread overview]
Message-ID: <1307326024.1083.1726649663326@webmail.proxmox.com> (raw)
In-Reply-To: <4611dc8b-ed62-47bd-a4b5-11e76459b299@proxmox.com>
> For this case, the index is initially copied over from the previous
> snapshot and chunk digests inserted into the known chunks hashmap.
> On client side, only changed chunks are uploaded via the backup api, and
> inserted in the fixed index on the corresponding index position. The
> information which previously indexed chunk it replaced is however lacking.
>
> Because of this, I currently tend to rather not modify the current
> behavior and stat all of the known chunks.
>
> Any thoughts on this? Is there a better approach I currently am failing
> to see?
No, sorry. But Gabriel pointed out that this will have a negligible effect in most cases, so we can keep the current code if too difficult to implement.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-09-18 8:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 13:59 Christian Ebner
2024-09-13 15:23 ` Dietmar Maurer
2024-09-17 7:19 ` Christian Ebner
2024-09-17 11:40 ` Christian Ebner
2024-09-18 8:54 ` Dietmar Maurer [this message]
2024-09-16 10:17 ` Gabriel Goller
2024-09-17 7:23 ` Christian Ebner
2024-09-20 13:42 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1307326024.1083.1726649663326@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.